Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store import should return store_id, model_id, errors if tuples failed to write #259

Open
aaguiarz opened this issue Feb 17, 2024 · 6 comments · May be fixed by #319
Open

store import should return store_id, model_id, errors if tuples failed to write #259

aaguiarz opened this issue Feb 17, 2024 · 6 comments · May be fixed by #319
Assignees
Labels
good first issue Good for newcomers

Comments

@aaguiarz
Copy link
Member

When you run

fga store import --file store.fga.yaml, it always displays {} as a result.

When there's no store configured, the fga store import command creates a new store first.

Later, the command writes a the model, and inserts the tuples.

The store_id is not returned, the model_id is not returned, and if an error happens when writing the tuples, the errors are not displayed either.

The command should display:

  • The store-id, when a new store is created
  • The model-id
  • The list of errors when writing tuples. We don't need to write the tuples that were successfully written, but maybe we should do it for consistency, as tuple write always does it.
@aaguiarz aaguiarz added the good first issue Good for newcomers label Feb 17, 2024
@edwin-Marrima
Copy link
Contributor

I'm going to work on this one

@aaguiarz aaguiarz assigned aaguiarz and edwin-Marrima and unassigned aaguiarz Apr 28, 2024
@aaguiarz
Copy link
Member Author

Thanks @edwin-Marrima! I just assigned it to you

@aaguiarz
Copy link
Member Author

@edwin-Marrima I apologize, but this issue was a duplicate of this #298, which was already fixed.

@aaguiarz
Copy link
Member Author

aaguiarz commented May 2, 2024

Closed as duplicated of #298

@aaguiarz aaguiarz closed this as completed May 2, 2024
@edwin-Marrima
Copy link
Contributor

edwin-Marrima commented May 3, 2024

@aaguiarz I was implementing a version that would provide to users tuples that were/weren't successfully imported. The current version is not doing that.

@aaguiarz aaguiarz reopened this May 3, 2024
@aaguiarz
Copy link
Member Author

aaguiarz commented May 3, 2024

Awesome! Let's do that then :)

@edwin-Marrima edwin-Marrima linked a pull request May 3, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants