This repository has been archived by the owner on Feb 2, 2021. It is now read-only.
WIP: Replace templating and custom deployment with Helm #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Waterdrips
force-pushed
the
waterdrips-helm-chart
branch
2 times, most recently
from
417795a
to
8fc513c
Compare
|
I want to a few deploys over a few sets of options (customer URL, customers secret, DO DNS, etc) before im willing to remove the WIP status. I also need to do a full feature-comparison with whats been removed vs added. |
Waterdrips
force-pushed
the
waterdrips-helm-chart
branch
6 times, most recently
from
d9987a4
to
247732a
Compare
Waterdrips
changed the title
Waterdrips
force-pushed
the
waterdrips-helm-chart
branch
4 times, most recently
from
b95ce84
to
8a2b86d
Compare
alexellis
reviewed
Nov 18, 2020
| @@ -114,7 +114,7 @@ secrets: | |||
| value_from: "~/Downloads/service-account.json" | |||
| filters: | |||
| - "gcp_dns01" | |||
| namespace: "cert-manager" | |||
| namespace: "openfaas" | |||
There was a problem hiding this comment.
Why did all these namespaces change?
There was a problem hiding this comment.
I would expect the DNS01 secret to continue to live in the cert-manager namespace?
alexellis
reviewed
Nov 18, 2020
| @@ -105,26 +103,6 @@ func Apply(plan types.Plan) error { | |||
| return dashboardConfigErr | |||
| } | |||
|
|
|||
| if plan.EnableOAuth { | |||
There was a problem hiding this comment.
How is this done going forward?
alexellis
reviewed
Nov 18, 2020
| @@ -133,12 +111,6 @@ func Apply(plan types.Plan) error { | |||
| return stackErr | |||
| } | |||
|
|
|||
| if builderErr := generateTemplate("of-builder-dep", plan, builderConfig{ | |||
There was a problem hiding this comment.
Certain that this is updated in the new chart?
alexellis
reviewed
Nov 18, 2020
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| rm -rf ./tmp/openfaas-cloud | |||
|
|
|||
| git clone https://github.com/openfaas/openfaas-cloud ./tmp/openfaas-cloud | |||
| git clone https://github.com/openfaas/openfaas-cloud --depth 1 ./tmp/openfaas-cloud | |||
There was a problem hiding this comment.
You can checkout a branch directly apparently with --branch
Not sure about SHAs though
alexellis
reviewed
Nov 18, 2020
|
@Waterdrips please could you see my comments? |
|
Yeh there's going to be a load of re work now we have multi arch. I'll address comments while doing the updates |
Waterdrips
force-pushed
the
waterdrips-helm-chart
branch
from
8a2b86d
to
508bb16
Compare
This commit replaces the custom OFC installation scripts (shell script and golang) with the OFC Helm chart which is pulled from the OFC release specified in the init.yaml. This has been tested using my init.yaml taken from a working cluster and applied to a new cluster (same init.yaml) with the new deployment method using the chart Signed-off-by: Alistair Hey <alistair@heyal.co.uk>
This should allow passing the --update-cloud flag which will only upgrade/install the OFC core components (chart AND stack.yaml etc) This also fixes the ClusterIssuer -> Issuer move so the secrets for DNS need to be in the issuer namespace Signed-off-by: Alistair Hey <alistair@heyal.co.uk>
Waterdrips
force-pushed
the
waterdrips-helm-chart
branch
from
508bb16
to
d06c02b
Compare
Waterdrips
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the custom OFC installation scripts (shell script
and golang) with the OFC Helm chart which is pulled from the OFC release
specified in the init.yaml.
This PR requires openfaas/openfaas-cloud#680 merged, and ofc-version
masterselected in ofc-bootstrap, or waiting for a new ofc releaseFixes #223
Fixes #154
Signed-off-by: Alistair Hey alistair@heyal.co.uk
Description
How Has This Been Tested?
This has been tested using my init.yaml taken from a working cluster and
applied to a new cluster (same init.yaml) with the new deployment method
using the chart
This was using Route53 DNS on a Civo k3s cluster
Checklist:
I have:
git commit -s