Skip to content
This repository has been archived by the owner on Feb 2, 2021. It is now read-only.

More configuration in gateway_config #196

Open
Waterdrips opened this issue Feb 28, 2020 · 5 comments
Open

More configuration in gateway_config #196

Waterdrips opened this issue Feb 28, 2020 · 5 comments
Assignees

Comments

@Waterdrips
Copy link
Contributor

Expected Behaviour

There are some settings that we might want to change, such as RO Filesystem, min/max replicas for scaling etc in the gateway_config.yaml, can we make those configurable, with the current values as defaults.

Current Behaviour

https://github.com/openfaas-incubator/ofc-bootstrap/blob/master/templates/gateway_config.yml#L30
https://github.com/openfaas-incubator/ofc-bootstrap/blob/master/templates/gateway_config.yml#L31
https://github.com/openfaas-incubator/ofc-bootstrap/blob/master/templates/gateway_config.yml#L32

Possible Solution

add these as defaults to example.init.yaml, and make them read that default, so we can set custom settings per cluster.

@alexellis
Copy link
Member

Discussed on a call, approved for implementation.

@alexellis
Copy link
Member

You should also template buildshiprun limits: https://github.com/openfaas/openfaas-cloud/blob/master/buildshiprun_limits.yml

@Waterdrips
Copy link
Contributor Author

check where else limits are set, see if we need to change anything else?

@alexellis
Copy link
Member

Add:

  • function_memory_limit_mb
  • function_cpu_requests_milli
  • function_cpu_limit_milli (we should disable this option for reasons

@Waterdrips
Copy link
Contributor Author

going to tackle this as part of moving to use the OFC Helm chart.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants