Change the order of checking cert-manager is ready before moving on #179
Conversation
|
Thanks for looking into this. I have one or two questions. Can you explain how openfaas relies on cert-manager for its installation? |
This was a misunderstanding - its actually this helm issue: helm/helm#6361 The helm client does a check on the endpoints to make sure they are all ready before continuing. Let me change the commit message and description |
We currently install cert-manager, then just install openfaas chart then we check if cert-manager is ready. This leads to openfaas failing to install because the webhooks for cert-manager don't exist and helm fails if any of the endpoints are not ready. See issue: helm/helm#6361 This has been tested by running before changing the code, and openfaas failed to install. Then I changed the order and ran against a new cluster. This install worked as expected. Signed-off-by: Alistair Hey <alistair@heyal.co.uk>
Waterdrips
force-pushed
the
fix-ordering-issue
branch
from
7cfd261
to
03467f8
Compare
|
So should we checking that cert-manager is ready and tightly couple to that, or check that helm is ready in some generic way between installing each component? I tend to think that the later would be more robust. |
|
It seems like we can just check that all API-servers are "Ready" before moving on and retain the original order? |
|
What are the steps I need to run to reproduce this? Can I do it with a new k3d cluster for instance without ofc-bootstrap? Do I just install cert-manager, then immediately try to install anything else with helm? |
|
I used anew civo cluster and ran of-cbootstrap. You can probably run |
|
We're going to address this via #182 instead of via changing the timing, changing the ordering / timing is likely to re-emerge as a similar issue later on. |
Description
We currently install cert-manager, then just install openfaas chart
then we check if cert-manager is ready. This leads to openfaas failing
to install because the webhooks for cert-manager don't exist and helm
fails if any of the endpoints are not ready. See issue:
helm/helm#6361
This has been tested by running before changing the code, and openfaas
failed to install. Then I changed the order and ran against a new cluster.
This install worked as expected.
Fixes #178
Fixes #168
Signed-off-by: Alistair Hey alistair@heyal.co.uk
How Has This Been Tested?
This has been tested by running before changing the code, and openfaas
failed to install. Then I chnged the order and ran against a new cluster.
Checklist:
I have:
git commit -s