Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmonCMS HTTPs fingerprint is not treated correctly #101

Open
llpamies opened this issue Jan 7, 2022 · 1 comment
Open

EmonCMS HTTPs fingerprint is not treated correctly #101

llpamies opened this issue Jan 7, 2022 · 1 comment

Comments

@llpamies
Copy link

llpamies commented Jan 7, 2022

I think that in emoncms.cpp, in this section:

    // Send data to Emoncms server
    String result = "";
    if (emoncms_fingerprint.isEmpty())
    {
      // HTTPS on port 443 if HTTPS fingerprint is present
      DBUGLN(F("HTTPS Enabled"));
      result =
        get_https(emoncms_fingerprint.c_str(), emoncms_server.c_str(), url,
                  443);
    }
    else
    {
      // Plain HTTP if other emoncms server e.g EmonPi
      DBUGLN(F("Plain old HTTP"));
      result = get_http(emoncms_server.c_str(), url);
    }

The condition should instead be:

    if (!emoncms_fingerprint.isEmpty())
@qm3ster
Copy link

qm3ster commented Jan 18, 2022

Fixed in #102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants