New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a button to show/hide password on the login page #7362
base: master
Are you sure you want to change the base?
Added a button to show/hide password on the login page #7362
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me.
hi @Prathmesh2498 , Neat stuff. Also agree code looks good. Just let us know this is testing well for you and then we will bring this into codebase. |
Hi @bradymiller, |
@Prathmesh2498 based on what I see in your code it should work in Safari, but if you can test that environment that would be the only one that sometimes behaves differently. When you've confirmed that we can go ahead and merge it in. |
@adunsulag Sure! I don't have access to a Mac device, but I should be able to get it in a couple of days. Will post an update after I test it on Safari. |
@Prathmesh2498 have you had a chance to test this on Safari yet? I'm setting this PR to go into the next patch unless I hear from you today (today's the final day for 7.0.2.1). |
@adunsulag unfortunately not yet due to finals week. |
@Prathmesh2498 Not a problem. We'll get it in the next patch then. |
Fixes #7361
Short description of what this resolves:
The fix adds a button with the eye icon to toggle the visibility of the password from masked to plain-text and vice-versa.
Changes proposed in this pull request: