Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a button to show/hide password on the login page #7362

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Prathmesh2498
Copy link

Fixes #7361

Short description of what this resolves:

The fix adds a button with the eye icon to toggle the visibility of the password from masked to plain-text and vice-versa.

Changes proposed in this pull request:

  • Add a button with the eye icon
  • Add script to select the button and toggle the password state from masked to plain-text as well as toggle the icon between eye and slash-eye states.

Show
Hide

Copy link
Sponsor Member

@adunsulag adunsulag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me.

@bradymiller
Copy link
Sponsor Member

hi @Prathmesh2498 , Neat stuff. Also agree code looks good. Just let us know this is testing well for you and then we will bring this into codebase.

@Prathmesh2498
Copy link
Author

Hi @bradymiller,
Yes, I have tested it on Firefox and Chrome in the development-easy docker environment, and it works fine for me.
Please let me know if it needs to be tested in any other environments.

@adunsulag
Copy link
Sponsor Member

@Prathmesh2498 based on what I see in your code it should work in Safari, but if you can test that environment that would be the only one that sometimes behaves differently. When you've confirmed that we can go ahead and merge it in.

@Prathmesh2498
Copy link
Author

@adunsulag Sure! I don't have access to a Mac device, but I should be able to get it in a couple of days. Will post an update after I test it on Safari.

@adunsulag
Copy link
Sponsor Member

@Prathmesh2498 have you had a chance to test this on Safari yet? I'm setting this PR to go into the next patch unless I hear from you today (today's the final day for 7.0.2.1).

@adunsulag adunsulag added this to the 7.0.2.2 milestone Apr 22, 2024
@Prathmesh2498
Copy link
Author

@adunsulag unfortunately not yet due to finals week.

@adunsulag
Copy link
Sponsor Member

@Prathmesh2498 Not a problem. We'll get it in the next patch then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show/Hide password button is not present on the login page.
3 participants