bug: excessive whitespace surrounding document viewer

[surfacehazard]

Describe the bug

The default vertical-align for table cells is "middle" on both Chrome-based and Firefox browsers. So, if the vertical alignment is not set, the content will be displayed with wasted space on both top and bottom.

[sjpadgett]

Is table bootstrap, doesn't sound like it. Maybe could be! Where is it located?
Never mind I see PR

[stephenwaite]

hi @surfacehazard , could you post a screenshot that shows the change please? thanks!

[adunsulag]

I've pulled this down on my local box and I can't see any difference from this change on Chrome version 119.0.6045.123.

[surfacehazard]

I've pulled this down on my local box and I can't see any difference from this change on Chrome version 119.0.6045.123.

It's only noticible if the window width is small enough to push the document viewer down (to the "middle"). I've already patched all of our systems, but I'll see if I can get a screenshot of the unpatched behavior.

[stephenwaite]

thanks @surfacehazard , no need, verified with your added details, thank you!

[surfacehazard]

I can no longer replicate the behavior in Chromium v124.0.6367.60 or Firefox v124.0.2. I did confirm that the document viewer TD still had "vertical-align: middle" from the default browser stylesheet - it does not inherit the "align-top" from the TABLE element. The PR I created simply added the "align-top" class attribute to the document "Contents" tab to bring it inline with what is on the document "Properties" tab.

[stephenwaite]

Okay, thanks @surfacehazard. It looks like the change that takes place in my Chromium v123 is that the TD is moved down below the popout which isn't looking very good. Going to close this issue.

[stephenwaite]

closing