Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Understand and address design tokens & CSS variable related issues in @edx/frontend-component-* repos #2348

Open
adamstankiewicz opened this issue Jun 2, 2023 · 1 comment

Comments

@adamstankiewicz
Copy link
Member

adamstankiewicz commented Jun 2, 2023

The shared frontend-component-{header|footer} JS libraries rely on SCSS variables and mixins that are no longer exposes/useful in a world where the consuming MFE is utilizing design tokens and CSS variables.

We will need to update the shared header/footer components to avoid making use of SCSS variables and mixins, in favor of the new CSS variables and custom media breakpoints generated from design tokens.

2 repos for Open edX:

2 repos for edX.org:

Note: we can execute on this task to get draft PRs ready to merge prior to releasing Paragon's alpha release to latest. Use the alpha version for now in package.json, but it should be quick drop-in replacement with latest once design tokens is merged into latest.

@PKulkoRaccoonGang
Copy link
Contributor

PKulkoRaccoonGang commented Jun 15, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In review
Development

No branches or pull requests

3 participants