Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONAR_EDITION not set in ods-sonar #350

Closed
michaelsauter opened this issue Dec 22, 2021 · 0 comments · Fixed by #351
Closed

SONAR_EDITION not set in ods-sonar #350

michaelsauter opened this issue Dec 22, 2021 · 0 comments · Fixed by #351
Assignees
@michaelsauter
Labels
bug Something isn't working
Milestone
0.2.0

Comments

@michaelsauter
Copy link
Member

While working on #295, I realized that Dockerfile.sonar does not set SONAR_EDITION correctly. The ARG/ENV is set in the builder image, which has no effect on the final image, see moby/moby#37345 (comment).

As a consequence PR scanning should not actually work in v0.1.1 and below ...

The issue hasn't been detected because of opendevstack/ods-pipeline-sonar#1 😢
@michaelsauter michaelsauter added the bug Something isn't working label Dec 22, 2021
@michaelsauter michaelsauter added this to the 0.2.0 milestone Dec 22, 2021
@michaelsauter michaelsauter self-assigned this Dec 22, 2021
michaelsauter added a commit that referenced this issue Dec 22, 2021
@michaelsauter
Set SONAR_EDITION in the correct image
c8b2c6e 
Fixes #350.
@michaelsauter michaelsauter mentioned this issue Dec 22, 2021
Merged
4 tasks
michaelsauter added a commit that referenced this issue Dec 22, 2021
@michaelsauter
Set SONAR_EDITION in the correct image
409d123 
Fixes #350.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelsauter michaelsauter

Labels
bug Something isn't working
Projects
None yet
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

Set SONAR_EDITION in the correct image opendevstack/ods-pipeline
1 participant
@michaelsauter