Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dothooks file no longer supported? #781

Open
chadamas opened this issue Jan 22, 2024 · 1 comment
Open

Dothooks file no longer supported? #781

chadamas opened this issue Jan 22, 2024 · 1 comment

Comments

@chadamas
Copy link

@jonpugh Is the Dothooks approach no longer the preferred way of executing deployment commands on the 1.x branch? The module is still there, but there doesn't appear to be a way to enable it in the project or environment settings. I did patch a workaround into our Devshop install, and it seems to function pretty much the same as it did in earlier versions, but if it's going to be removed entirely at some point, I'd rather not do that.

I haven't had much luck using the deploy steps in the composer.json file--the deploy:build step throws an error on new site installations, almost like it's trying to fire before the site is actually installed (interestingly, if the site is already built, the deploy:build step appears to work). I've also tried adding some custom scripts to Composer's standard events (e.g. post-install-cmd), but I'm not sure how best to get the site alias to use for Drush commands going that route.

If you have any advice or info you'd be willing to share, I'd really appreciate it! Thank you.

Copy link
Member

jonpugh commented Jan 26, 2024

Heya,
I really appreciate hearing from you. I don't even know how much devshop is used. I've been ready to give it up.

It's been very painful to develop and support, so I've been trimming things down, perhaps too much.

Your right. I shouldn't remove dothooks. I should just mark it deprecated.

A .hooks.yml file is still a possibility, but we should go about it in a different way.

If you can submit a PR to revert the removal of devshop_dothooks, I would merge it. Otherwise, I will get to it at some point.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants