Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for defaulting and validating webhooks #15

Open
dhirajsb opened this issue Nov 7, 2023 · 0 comments
Open

Add support for defaulting and validating webhooks #15

dhirajsb opened this issue Nov 7, 2023 · 0 comments
Assignees
Labels
kind/enhancement New feature or request

Comments

@dhirajsb
Copy link
Contributor

dhirajsb commented Nov 7, 2023

Is your feature request related to a problem? Please describe.
Kubernetes supports calling controller webhooks for setting default values and validating custom resources. MR controller should support this feature to improve operator usability.

Describe the solution you'd like
Add support for webhooks for defaulting and validation. The webhook config and code has been generated, but not enabled yet. It requires setting certificates using a k8s certificate manager, which needs to be investigated to determine how that will function in odh operator installs.

Describe alternatives you've considered
The alternative is to try to set default values and do validation on every reconciliation, which is inefficient.

Additional context
See: https://book.kubebuilder.io/cronjob-tutorial/webhook-implementation

@dhirajsb dhirajsb added the kind/enhancement New feature or request label Nov 7, 2023
@dhirajsb dhirajsb self-assigned this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

1 participant