Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate InstaScale out from default KFDEF #12

Closed
anishasthana opened this issue Mar 22, 2023 · 5 comments
Closed

Separate InstaScale out from default KFDEF #12

anishasthana opened this issue Mar 22, 2023 · 5 comments

Comments

@anishasthana
Copy link
Member

Most users will always want MCAD available in their clusters, but they may not want InstaScale. We should separate out InstaScale into a separate overlay/manifest set so as to increase the flexibility of deployment.

@jbusche
Copy link
Contributor

jbusche commented Mar 22, 2023

I wonder if it might be possible to add to the CR the image for these KFDEF? For example, instead of using

quay.io/project-codeflare/instascale-controller:latest

I wonder if it'd be possible to override the image, cpu, memory so they could be changed just by editing the CR?
Like being able to override to this:

quay.io/project-codeflare/instascale-controller:v0.0.2

@jbusche
Copy link
Contributor

jbusche commented Apr 4, 2023

Would it have it's own kfdef maybe? Then when we're doing the E2E tests, we could check the existence of the instascale kfdef and make sure it's deleted/resources are gone.

@anishasthana
Copy link
Member Author

  1. Yeah, we could definitely add those to the CR.
  2. re: the kfdef thing, yeah, that's an option!

@accorvin
Copy link
Member

accorvin commented Apr 4, 2023

We've discussed putting the image in the CR in recent team meetings and explicitly said we don't want to do this. The thought was that a specific version of the codeflare operator should be tied to specific versions of the operands, enduring deterministic behavior for a given version of the stack.

@astefanutti
Copy link
Contributor

Closing as it's become obsolete with the operator redesign.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants