Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test case for s3-to-dc single absolute s3 path uri #486

Closed
wants to merge 2 commits into from

Conversation

pindge
Copy link
Contributor

@pindge pindge commented Jun 28, 2022

  • allow s3-to-dc to index when provided uri is a absolute s3 path

@pindge pindge self-assigned this Jun 28, 2022
@pindge pindge linked an issue Jun 28, 2022 that may be closed by this pull request
* split s3 path if file name is in base
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #486 (5ee3bb9) into develop (7ae2760) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #486      +/-   ##
===========================================
+ Coverage    55.21%   55.33%   +0.12%     
===========================================
  Files           46       46              
  Lines         3789     3793       +4     
===========================================
+ Hits          2092     2099       +7     
+ Misses        1697     1694       -3     
Impacted Files Coverage Δ
libs/cloud/odc/aws/_find.py 97.67% <100.00%> (+0.23%) ⬆️
libs/cloud/odc/aio/__init__.py 60.62% <0.00%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ae2760...5ee3bb9. Read the comment docs.

@pindge
Copy link
Contributor Author

pindge commented Jun 30, 2022

Won't merge

@pindge pindge closed this Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

s3-to-dc does not index when s3 url doesn't contain *
1 participant