Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in LandmarkLBF.cpp #3581

Open
TonyCongqianWang opened this issue Oct 21, 2023 · 1 comment
Open

Typo in LandmarkLBF.cpp #3581

TonyCongqianWang opened this issue Oct 21, 2023 · 1 comment

Comments

@TonyCongqianWang
Copy link

TonyCongqianWang commented Oct 21, 2023

In the supportVectorRegression(...) function of LandmarkLBF.cpp there is a typo. lambda and upper_bound were declared as a size 1 array, but it was supposed to be a size l array! This can be verified by looking at the "original" code the algorithms was based of. And indeed, on github, it is almost impossible to tell the difference between l and 1. This typo results in some nan values and occasional crashes due to segfaults (not suprising, considering the array size is too small!).

scikit-learn/scikit-learn@2b60d32#diff-bf60bef97c003384f56a1fd92fe102f6ac1eea40298e911dd95b4d28601bbc14
(line 830 in linear.cpp)

@asmorkalov
Copy link
Contributor

@TonyCongqianWang Thanks a lot! Feel free to submit PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants