Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Tax Forms to fiscal hosts #7389

Open
Betree opened this issue Apr 25, 2024 · 0 comments
Open

Link Tax Forms to fiscal hosts #7389

Betree opened this issue Apr 25, 2024 · 0 comments
Labels
api Issues that require some work on the API (https://github.com/opencollective/opencollective-api) complexity → complex frontend
Projects

Comments

@Betree
Copy link
Member

Betree commented Apr 25, 2024

Related to #7346
Related to #6948

Tax forms are currently shared across fiscal hosts: if you have expenses on both OCF and OSC and submit your tax form, both hosts will have access to the same instance/file.

While this pattern simplifies the UX, it pauses a bunch of concerns:

  1. Any action taken by one fiscal host (e.g., Ability to Invalidate a tax form #7134 or Ability to mark a tax form as "Not required" #6225) will be applied globally. Yet, marking a tax form as "Not required" on OCF shouldn't mark it as Not required for OSC.
  2. When tax forms are manually marked as received, the first fiscal host may set a link that the second host is not allowed to see (that would be resolved by Ability for fiscal host admins to manually upload a tax form #7375)
  3. Not having this relationship forces us to run complex queries to list the tax forms attached to a given host (see [Project] Tax Forms Admin #7346 (comment) for details).
  4. Given how sensitive this information is, we should make sure we get the payee's explicit approval before sharing their tax information with the new host.
  5. We've defined that, in the future, we may want to encrypt tax form information using a host-specific secret. This requires having one tax form instance per host.

Proposal

API

  • Add a HostCollectiveId column to LegalDocuments
  • Seed the values of HostCollectiveId, duplicating rows if needed (1 legal doc/payee/year/host)
  • These "duplicated" documents can still share the same URL
  • Update the tax form queries to group by host

UX

When a payee is required to submit a new tax form for Host B while they already submitted one to Host A, show them two options:

  1. Copy already-submitted tax form (could be a list if multiple options)
  2. Submit a new tax form
@Betree Betree added complexity → complex api Issues that require some work on the API (https://github.com/opencollective/opencollective-api) frontend labels Apr 25, 2024
@Betree Betree added this to To do in Tax forms via automation Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issues that require some work on the API (https://github.com/opencollective/opencollective-api) complexity → complex frontend
Projects
Development

No branches or pull requests

1 participant