Renaming "Merchant ID"

[gustavlrsn]

Description

We're using Merchant ID as a reference to the ID of a transaction/payment/subscription/virtual card from an external payment processor, see reference:

export const MERCHANT_ID_PATHS = {
  [CONTRIBUTION]: [
    'data.charge.id', // stripeId
    'data.capture.id', // onetimePaypalPaymentId
    'data.paypalSale.id', // recurringPaypalPaymentId
    'data.paypalResponse.id', // paypalResponseId
  ],
  [EXPENSE]: [
    'data.transfer.id', // wiseId
    'data.transaction_id', // paypalPayoutId
    'data.token', // privacyId
    'data.transaction.id', // stripeVirtualCardId
  ],
} as const;

This definition differs from what seems to be commonly defined as merchant ID (a 15 digit number referencing a business entity):

• https://www.forbes.com/advisor/business/software/merchant-id/
• https://stripe.com/en-se/resources/more/merchant-id

We've discussed renaming this to something closer to what it represents.

Naming options

• Payment processor ID
• Payment service ID
• External transaction ID
• External transaction ref
• External payment ID
• Payment service ref
• ... feel free to add more

Tasks

Beta Give feedback

1. Add dedicated columnn to transactions table
2. Update MerchantId resolver and TransactionsCollectionQuery filter
3. Remove existing data based indexes

[iamronen]

I propose "External Reference ID"

attn @gustavlrsn @znarf