Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configurable securityContext for all involved components #641

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

grieshaber
Copy link

Description

This PR allows users of the Chart to declare custom security contexts for pods and containers. As a default, the hardcoded values from before are still delivered in the values.

By doing that, one could for example add a seccomp profile easily and the chart can be deployed to more restricted environments again.

In favor of a more readable and comprehensive solution, I dropped the global.openShiftRestricted flag. For non-open shift users, behavior is as before. OpenShift users need to overwrite the UID and GID in the values files now directly. The corresponding install command for open shift cluster is adapted to the new flags.

Additionally, I changed the used UID for kubeclarity image - again, for the sake of simplicity of the chart. As there is no USER directive in the Dockerfile or any other UID-bound commands (like mkdir / chmod / ... ) it should be just fine. I started it in local kind cluster and could not find any issue.

Resolves #626 and #599

Type of Change

[ ] Bug Fix
[X] New Feature
[ ] Breaking Change
[X] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@grieshaber grieshaber requested a review from a team as a code owner May 15, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant