Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprication error in custom_field.php #12994

Merged
merged 1 commit into from Nov 24, 2023
Merged

Conversation

AJenbo
Copy link
Collaborator

@AJenbo AJenbo commented Nov 22, 2023

Fixes #12978

@condor2
Copy link
Contributor

condor2 commented Nov 22, 2023

Warning: preg_match(): Delimiter must not be alphanumeric, backslash, or NUL in admin\controller\customer\custom_field.php on line 387{"error":{"validation":"error_validation"}}

Also I don't see an warning message in admin like...This regex is invalid...

No error_validation in language file

@AJenbo
Copy link
Collaborator Author

AJenbo commented Nov 22, 2023

Warning: preg_match(): Delimiter must not be alphanumeric, backslash, or NUL in admin\controller\customer\custom_field.php on line 387{"error":{"validation":"error_validation"}}

That's a separate issue and you can avoid it by entering a valid regex pattern as the validation rule.

@condor2
Copy link
Contributor

condor2 commented Nov 22, 2023

yes...but there is no warning message to display in admin.....

@AJenbo
Copy link
Collaborator Author

AJenbo commented Nov 22, 2023

Ok, but it's not going to be something I solve in this PR. I would suggest you create another issue about it.

@danielkerr danielkerr merged commit e78b597 into opencart:master Nov 24, 2023
4 checks passed
@AJenbo AJenbo deleted the patch-1 branch November 24, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Master] No error message when regex validation is invalid
3 participants