OpenCart 4.0 Discussion

[danielkerr]

I thought I would open this thread to discuss the progress of OpenCart 4.

While it looks like there is still a lot of work I have completelted all the big tasks.

I'm close to finishing the new checkout system which has caused me delay over the last 2 months.

The list of tasks still to compelete can be found here:

https://github.com/opencart/opencart/projects/5

[eka7a]

Static files (bootstrap, jquery, fontawesome etc) can be collected in a common directory.

In its current form, it is necessary to update each separately for each update. Sometimes one updates and one does not.

And they take up a lot of space. Especially fontawesome files.

[todavy]

Is this the correct place to put wishes for features in version 4? Anyway, Theese are the things I wish for this Christmas and I've been a good boy! :)

Assign multiple customer groups to one customer (not only one)
Possibility to copy the standard theme with only one click
Possibility to create a new language with only one click
A simple blog
Possibility to remove adress field "Region" for countries that do not use regions
Possibility to make en manual order in admin (Sales - Orders - Manual) without confirmatipon mail beeing sent to customer.
Possibility to change the order of products in module Featured without rearranging the whole list
Plus-minus button on product page buy button to add number of items
Possibility to display deeper subcategory structure in top menue and vertical menue (module)
Possibilty to set coupon discount on gross price (price including tax) and calculate the tax backwards.
Possibly to hide the grey text "price without tax" in all thumbnails.
Possibly to divide tax on frieight in parts equal to the product prices or at least change the tax to the lowest tax in one order (if all products are books (whitch has 6 % vat in Sweden) the tax on the freight should also be calculated as 6 % on this order.
One-page-checkout option
Possibility to add products to bundles and have a correct stock subsctraction of all the products in the bundle

[TheCartpenter]

Adding this commit into discussion, as requested: #10291 (comment) .

[bankeris]

Hello,
Is there any ETA when OC 4 comes to life?
The last release OC 4..b was 4 years ago. Can we have another version or more info ? :)

[condor2]

I think is much better to use date_format in every language file then in twig file.
Example:

$_['my_date_format'] = 'YYYY-MM-DD';

And this can be changed to:
$('.date').datetimepicker({
'format': '{{ my_date_format }}',
'locale': '{{ datepicker }}',
'allowInputToggle': true
});

Or something in store settings

[TheCartpenter]

catalog/controller/account/subscription.php

260ca7f#diff-a5bf7894a5a350cc61cdb87f2ba9a1dbd79cf0c167506a4ca093060731f2a21cR8

260ca7f#diff-a5bf7894a5a350cc61cdb87f2ba9a1dbd79cf0c167506a4ca093060731f2a21cR35

260ca7f#diff-a5bf7894a5a350cc61cdb87f2ba9a1dbd79cf0c167506a4ca093060731f2a21cR46

account/subscription

[TheCartpenter]

catalog/model/checkout/order.php

260ca7f#diff-8a411bab48c8ec9314a95d12e240b70b721f56c0142bee659547157bf4d0cee8R23

// Add subscription

at least ... otherwise, testers may not go far ...

[mullernato]

How to create and install a theme in this "Master Branch (4.0.0.0_b)" version? I even tried, the installation worked but the theme did not load, even though I configured everything correctly in the admin panel! What is missing? What would be the correct folder structure for the theme to load?
I am sending the theme attached to this message for structure analysis.
glad.ocmod.zip

[mhcwebdesign]

@mullernato: There are still issues with the folder structure and namespaces, see e.g. #9591 causing the extension installer to fail. The namespace issue needs to be addressed, it should really reflect the underlying folder structure, similar to what is common practice in other programming languages, such as Java.

Until then, there is no point in trying to write extension for OC 4. It's still work in progress.

[danielkerr]

@mhcwebdesign dont be giving advice of when stuiff is rready. the new extension system has been ready months

[mullernato]

@danielkerr - Mr. Daniel, good night, I tried to make a theme for this new version 4.x, I managed to install and assign the store normally, but the store frontend did not load the created theme. Could you help me by evaluating what I did wrong?

[TheCartpenter]

This line will create problems with Windows users especially when using virtual servers: 63c195a#diff-07626562ea150e132e1a0238aecd3d4c4d9514ca249b327a8538043fbab24170R134 .

[totalsportUA]

https://totalsport.ua/

[danielkerr]

everything is done using events. so if u setup an event so that any template files that are called uses prepends extension/code to all views. i will try to make a guide.

…

On Sun, Jan 23, 2022 at 10:22 AM Müller Nato ***@***.***> wrote: @danielkerr <https://github.com/danielkerr> - Mr. Daniel, good night, I tried to make a theme for this new version 4.x, I managed to install and assign the store normally, but the store frontend did not load the created theme. Could you help me by evaluating what I did wrong? — Reply to this email directly, view it on GitHub <#10251 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGYFTCF7KXMKUDQ3XHQD43UXNQ5XANCNFSM5GO37MJA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[condor2]

I think renaming admin folder is a bad idea.
And should be a setting to change only the path/URL.

For example you have option to rename to : my_loginX

admin folder should be the same and you should be able to login when you type store.com/my_loginX and when you type store.com/admin should give a 404 error.

[TheCartpenter]

Not sure if this line would be ideal to use during an upgrade extraction ...

e597092#diff-0eed743712d43ba891d1ba8debbeb83d2c221b17fe79dfd712191d8c4a069f07R29

[TheCartpenter]

Shouldn't contain an empty case on a model: 8b5137e#diff-31529b7ef307d3ffe69bca71909a11a8bfc4cf54386be7d837c790259b3559cfR85 .

[007amitgarg]

Import Export of products and customer is the most basic feature always missing in OpenCart.

[sylvainliang]

First quarter of year 2022 almost end, any news on the release of OC4?

[TheCartpenter]

Returns have been worked on the opencart-3 repository as well. In the meantime, I have noticed that the master branch's admin/model/catalog/filter.php file uses conventional method names that other models do not; getGroup(), getGroups() would be two of them.

Furthermore, there are also un-renamed Ajax URL method structures; they're all using lowercase names compared to the controllers. Also. there are explode(',' commands that refers to the $this->config->get('config_mail_alert_email') where two have a (string) cast in front but two others don't.

[danielkerr]

4.0.0.0 shouldbbe ready very soon. im fixing a few things then testing every page.

…

On Fri, Apr 8, 2022 at 11:22 AM sylvainliang ***@***.***> wrote: Looks like long way more to go before we can have a stable v4.0. I guess we can only use v3.0.3.8 for now. — Reply to this email directly, view it on GitHub <#10251 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGYFTA4L6RY2GWLNUQZVJLVD6Q55ANCNFSM5GO37MJA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[ghost]

4.0.0.0 shouldbbe ready very soon. im fixing a few things then testing every page.
…
On Fri, Apr 8, 2022 at 11:22 AM sylvainliang @.> wrote: Looks like long way more to go before we can have a stable v4.0. I guess we can only use v3.0.3.8 for now. — Reply to this email directly, view it on GitHub <#10251 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGYFTA4L6RY2GWLNUQZVJLVD6Q55ANCNFSM5GO37MJA . You are receiving this because you were mentioned.Message ID: @.>

@danielkerr do you have any new information when you are going to release the new version? We would like to use it so any information is welcome. It's been a month.

[danielkerr]

version 4 is already out. the next version should be this month.

[ghost]

version 4 is already out. the next version should be this month.

Thank you for the answer. We have tested the currently released version and it has some outstanding issues that are blocking us from using it that is why I have asked. Glad to hear next version is close. Will wait and test again if it's good enough to be used in production.

[TheCartpenter]

version 4 is already out. the next version should be this month.

Thank you for the answer. We have tested the currently released version and it has some outstanding issues that are blocking us from using it that is why I have asked. Glad to hear next version is close. Will wait and test again if it's good enough to be used in production.

If you do encounter issues with the latest OC 4 release, please report them in the issues tab if it hasn't been reported before or, if you have a solution with code, please submit a pull request with description.

[karan982]

@TheCartpenter I have question in product form at Admin panel how to make UPC field required ?
Currently Form validation and product save functions are in save functions. I am not sure how to make the same required with Evens without splitting validation in separate Public function.

[TheCartpenter]

On how to build events, please use the OC forum or download a free extension from the Marketplace on how to proceed with OC 4 extensions. There are several examples that can be used.

[karan982]

I am already familiar with events system and see my list of extensions that are in opencart 4x.
https://www.opencart.com/index.php?route=marketplace/extension&filter_download_id=67&filter_member=CodingInspect

The problem I shared has very simple solution in OCMOD but with events there is no way to do so.

If you have idea share it, otherwise I also provided the possible way to achieve the same by change in core files code - separate validation function and execute via load controller or ajax before save product data into database.

There are also a case of no events for library cart file addCart() function.
again in OCMOD we can add piece of code in any library file. But with events there is no way unless implement the same logic using for model file functions.

[mhcwebdesign]

There are also a case of no events for library cart file addCart() function. again in OCMOD we can add piece of code in any library file. But with events there is no way unless implement the same logic using for model file functions.

I am about to complete an extension for OpenCart 4 which had to modify the system/library/cart/cart.php. When done, I'll publish an article on how to modify library classes which involves a simple usage of a decorator design pattern.

[FelipoAntonoff]

I am already familiar with events system and see my list of extensions that are in opencart 4x. https://www.opencart.com/index.php?route=marketplace/extension&filter_download_id=67&filter_member=CodingInspect

The problem I shared has very simple solution in OCMOD but with events there is no way to do so.

If you have idea share it, otherwise I also provided the possible way to achieve the same by change in core files code - separate validation function and execute via load controller or ajax before save product data into database.

There are also a case of no events for library cart file addCart() function. again in OCMOD we can add piece of code in any library file. But with events there is no way unless implement the same logic using for model file functions.

Really a detail of Opencart 4 is the lack of OCMOD. Event is basically a trigger system per Event, while OCMOD's proposal is much broader, unfortunately I haven't found in Opencart 4 something that correctly and 100% replaces all types of OOCMOD natively.

I think there is a lack of more examples of using more complex Events and what is the limit of it or better to create a system that really replaces OCMOD.

For example, until today I have no idea how an Event can change a Controller or Model, for example, while in OCMOD we look for the line and that's it.

Another point is the ease of creation and maintenance, try to change a view by Events, possible with a certain kludge, but the complexity for this does not make any sense, I am still in favor of returning to OCMOD or a similar system, I consider it to be your mistake removal without another option that can replace it 100% and with better quality of implementation, maintenance and use.

[ansleyD]

I installed opencart 4 and I want to change country controller file without change the original file but when I create extension it didn't work, how we can create my own extension and it will work fine.
I read about using events with extension, so please if you guide me to the correct way to create my own extension.

[FelipoAntonoff]

@padaliyajay Excellent idea for certain use cases, if it's small changes it might work, but with XML depending on the line it would be faster, I understand.

Now about the JS idea I found some Headless Commerce and I found the idea very interesting.
Basically Front is made entirely in JS, consuming an API, being able to use Vue.js, React and etc, there are even E-commerce Front projects only, the research I did https://github.com/search?q=ecommerce&type=repositories&s=stars&o=desc, maybe it will inspire some concepts for Opencart, it has some with excellent use cases, roadmap and other details.

I just don't know if it would be the focus of Opencart, because a lot of resources are tied to the traditional look and it would take a very big rewrite, but it would be very modern.

In Laravel itself it is divided, there is a project focused on Twig and another on using Vue.js lol, there are people who prefer the visual to be processed through the Back End and others that the Front End only consumes an API.

Now the cool thing about a Front by API is the freedom of customization and visual modularity, but it increases dependencies and requires more JS skills.

Examples of visuals for E-commerce:
https://github.com/vuestorefront/vue-storefront
https://github.com/vercel/commerce

Interesting that it would be possible to use some good visual project and just apply the Opencart API to it, for example.

[padaliyajay]

@FelipoAntonoff
opencart has started rolling cloud service as a shopify doing. so something like ocmod could't use in cloud service because it is unstable and most of time create conflict with other code. but event and wrapper things looks complex but it is reliable than ocmod in term of stability.

and for js frontend, i can see opencart slowing moving toward Ajax operations more. you can see in opencart 4, most of form is based on ajax now. so in future i think frontend will be in JS. maybe in next OC 5 or 6

[FelipoAntonoff]

@padaliyajay about cloud I think they are not responsible for what the customer installs in the Store, with me OCMOD/vQmod has always worked 100%, as it generates a cache I think it is unlikely that there is another better option and nothing would stop it from being improved after all, there is no perfect tool, Events and Wrapper are still limited in their uses, I believe they are all options and complementary, we can discuss more about it here #10883, I even suggested creating one This way, a migrant would validate 100% if there is a replacement and would also make it easier for thousands of professionals.

About Front it seems that they intend to create a new theme for 4, maybe it's not the time to change Front to JS, if not probably stay for 5 or always Twig + JS which is another option, but having a more API complete for those who prefer to use only JS in Front.

Opencart 4 now needs stability and we need to be more attentive to releases, because as it is E-commerce it has to be well tested, something that unfortunately 4 was not, because I should have continued with 3 and 4 was launched when I was ready lol , but anyway they are just paupites.

[mhcwebdesign]

Javascript-based frontends would be a disaster, using Ajax is bad enough, when simple HTML POST forms used to do the job just fine. OpenCart 4 hasn't even reached a stable stage, and yet there are already a number of poor quality extensions in the OpenCart marketplace.

What's really needed is a better project management for OpenCart: Make proper beta-releases and give users and developers a chance to test it all out and to report bugs, before a final stable release. Instead we saw a series of unstable OpenCart releases from 4.0.0.0 to 4.0.2.1, and IMHO none of them isn't yet stable enough for a live website.

[FelipoAntonoff]

Actually JS can be a little more complicated and it would be necessary to analyze it very carefully, I already had to revert a 100% JS project in Front to Twig + JS, but it seems that it has become common view 100% JS.

About the Marketplace, the problem is the lack of curatorship and there are many professionals who unfortunately only put their names to the work of other colleagues. I even know even professionals with the Opencart seal who want to know how to code, it would be good to better curate with partners and products, in addition to avoiding module with encryption for security.

I agree about the launch, I even posted about it with some tips: #11419, I didn't understand why it was released, because even with a 5-10 minute test it was already possible to see several details and even 1 year later it is still not ready for production, I hope it serves as a learning for the future of Opencart, Opencart 3 I think was probably the best release of Opencart, since 2 was not very good either, but in 2.3.0.2 it was already quite stable.

[newbie7777]

The order editing and processing process is more than good, just unique. There are a lot of new things and everything works more than well, just unique, I have more than 500 customers under opencart, most of them called me and want an update, they are just impressed.

[FelipoAntonoff]

Opencart is in fact generally the best E-commerce system in the world, one of the few that is 100% modular, low consumption, high performance, great usability, in fact it doesn't have a direct competitor.

But it competes indirectly with rented Stores even if the vast majority are much lower than it, what Opencart lacks is just maybe a roadmap, more detailed changelog, more articles/documents, marketing, focus on releasing only mature versions, a replacement to OCMOD (XML), improvements in events and more use cases, and finally small details that are not directly linked to the platform.

For now our customers are using Opencart 3 more, but soon Opencart 4 should start to be more used, it is important that it becomes stable and mature.

We have around 2-3 thousand Opencart 3 stores, which passed Opencart 2 a long time ago, 4 still no stores, but we are also going to start focusing more on 4 due to new versions that must have corrected most of the bugs and we will also contribute by checking and, if necessary, correcting some possible details.

It would also be nice to have a maintenance/support period between Opencart versions similar to how Laravel and Symfony do, so we have an idea of how long an Opencart version will be maintained and also a forecast for new releases.

[danielkerr]

hank you very much

[padaliyajay]

Please release stable new version of opencart 4 from master.

[condor2]

Yes, from Master Branch

[padaliyajay]

Ok. thanks

[FelipoAntonoff]

The problem with Opencart 4 was that it was released before a stable version and they took away important developer features like OCMOD without having a replacement that can do the same things with the same quality.

I even suggested at one time to focus on Opencart 3 publicly while Opencart 4 was in development until it was ready for production.

Unfortunately, launching something that is not stable is very complicated, as a new customer will want to use Opencart 4, but the use of Opencart 3 will be indicated, he will be confused and will also think about the work that will be after migrating from 3 to 4, so the ideal is always to be released only when it is stable for production, I also miss a roadmap and other points that I have already suggested here: #11419

The new Checkout also seems to me to have taken a lot of time and still doesn't have good usability and maturity, I even suggested using the Checkout Lite base that we made for our customers using Vue.js, maybe the ideal would be in Opencart 4 to focus more on update the libraries and languages and then focus on more features and changes as 3 overall is pretty stable.

The new theme would be even more relevant even before a new Checkout, as this would prevent developers from having to migrate twice, because when the new theme arrives in Opencart 4, it will require migration of modules for it and a new theme would place Opencart in a more modern and current view, even reducing the use of bad or non-standard themes that unfortunately spoil stores in general.

Now I understand that talking is easy, really maintaining a platform is not something trivial, but Opencart has a team, community and maturity of more than 10 years and will certainly manage to make Opencart 4 stable and in the future the most indicated, I will also work more for that too.

[RicardoCostaTW]

You are right on all points. The platform is very unstable and checkout is very slow.
Day 3th of May i have a go-live with opencart 4 and i'm afraid!

[FelipoAntonoff]

@RicardoCostaTW Complicated, meanwhile Opencart 3.0.3.8 is the most suitable, even after more than 1 year of Opencart 4 :(, time that it was for Opencart 4 to be very stable and the most suitable for new stores and even start the indication migration from 3 to 4.

Try to use the latest version of Opencart 4 and do some tests, depending on the bug it pays to try to fix it before the live.

Now I hope it serves as a link for future Opencart releases and learning for all of us, we have an excellent platform made by Daniel and the team, which has always been well ahead of its time, but needs to continue to evolve and with greater Community participation and transparency ( Roadmap, support and release plan...), there are several ways to improve Opencart, some cited by several colleagues and myself.

In the case of 4, basic tests were lacking, the ideal is to test all stages of purchase, administration, etc., even if it is a manual test or with a script and it is good to avoid changes that can affect thousands of plugins and professionals, such as the removal of OCMOD without another viable alternative.

Now I'm going to start using Opencart 4 in the 2nd semester, I'm going to fix the most emergency bugs and make a Pull Requests of them in case Opencart wants to put them in the code too, I hope to be able to contribute even more to the community.

Let's together make Opencart 4 stable in 2023, the sooner the better to start being the most suitable and having more good plugins/modules, so after that it can be focused on improving it even more. We have to show that Opencart 4 remains strong and the most suitable for serious E-commerce, open (not vendor lock) and high performance.

[danielkerr]

Now the cloud is launched I need wait for subscriptions to increase then I can start hiring people from the community to supply support and help with development.

[FelipoAntonoff]

Very good Daniel, about Cloud, could you put a link in the Menu to highlight more.

It will be great to have more investment for Opencart and people contributing, this year I will also focus a little more on the core of Opencart and make some contributions, it would be good to check the Pull Requests and also the Coding Standards that the link is not getting, I made an issue here about #12287

Opencart could also use the Github sponsor for contributions or https://opencollective.com/, so it would have even more investments, in addition to the Marketplace and Cloud, perhaps even giving back to those who invest credits to use in the Marketplace or Cloud of Opencart and highlighting them on Github and on the Opencart page, a good example of using Open Collective Vue.js.

So a portion of the Opencart revenue could help pay developers who make contributions or leave some more fixed, speeding up Opencart 4 in production and Opencart more prepared for the future.

[mhcwebdesign]

@danielkerr : I think it would be good to do public beta-releases before a new stable release, so that users and developers have sufficient time to do testing, better than releasing a series of unstable 4.0.x.x releases.

[FelipoAntonoff]

It's a good idea, in 2 and 3 I think there were betas, the best release I found in 3, I thought it was beautiful that every module takes from 3.0 to 3.0.3.8 without needing N versions for each sub version.

It would also be good for bug fixes to be released as soon as possible, like fixed something, it's already released, because they are small fixes or security upgrades, in addition to automated tests, perhaps visual and logical, nowadays there are many tools to automate tests, such as PHPUnit, Pest, Codeception, among others, I believe that those that test interacting are easier to implement, so if you have a bug in an important resource such as Registration and Checkout, you will detect it.

I also think that Opencart maybe needs to focus more on Core as it always has and on technologies to keep updated and secure, not so much on features, as it makes it precisely the best E-commerce, as there is no other option with good performance, modular and easy to use, the others are too bloated, slow and consume a lot of resources, precisely because they focus too much on having everything, and with a strong base can be complemented with Plugins / Apps, the most important being the base than having a resource X or Y included more incomplete or difficult to maintain.

I also think we need more development tools, only Event I think makes Opencart incompletive and limited. Perhaps tools that help create tests, creating Modules like Symfony and Laravel do well with CLI, Github itself also has some Actions to do various things like analyze code, test, more automates approval of Pull requests and etc.

[karan982]

Hello All,

I need help regarding cart library __construct function in opencart 4x. see the below code.

MY code is between the comment.
/* Codinginspect Extension Starts /
/ Codinginspect Extension Ends */

`public function __construct(\Opencart\System\Engine\Registry $registry) {
	$this->db = $registry->get('db');
	$this->config = $registry->get('config');
	$this->customer = $registry->get('customer');
	$this->session = $registry->get('session');
	$this->tax = $registry->get('tax');
	$this->weight = $registry->get('weight');

	// Remove all the expired carts with no customer ID
	$this->db->query("DELETE FROM `" . DB_PREFIX . "cart` WHERE (`api_id` > '0' OR `customer_id` = '0') AND `date_added` < DATE_SUB(NOW(), INTERVAL 1 HOUR)");

	/* Codinginspect Extension Starts */
	$this->db->query("DELETE FROM " . DB_PREFIX . "codinginspect_extension WHERE (api_id > '0' OR customer_id = '0') AND date_added < DATE_SUB(NOW(), INTERVAL 1 HOUR) AND email = ''");
	/* Codinginspect Extension Ends */
	
	if ($this->customer->isLogged()) {
		// We want to change the session ID on all the old items in the customers cart
		$this->db->query("UPDATE `" . DB_PREFIX . "cart` SET `session_id` = '" . $this->db->escape($this->session->getId()) . "' WHERE `api_id` = '0' AND `customer_id` = '" . (int)$this->customer->getId() . "'");

		// Once the customer is logged in we want to update the customers cart
		$cart_query = $this->db->query("SELECT * FROM `" . DB_PREFIX . "cart` WHERE `api_id` = '0' AND `customer_id` = '0' AND `session_id` = '" . $this->db->escape($this->session->getId()) . "'");

		foreach ($cart_query->rows as $cart) {
			$this->db->query("DELETE FROM `" . DB_PREFIX . "cart` WHERE `cart_id` = '" . (int)$cart['cart_id'] . "'");

			/* Codinginspect Extension Starts */
			$this->db->query("DELETE FROM " . DB_PREFIX . "codinginspect_extension WHERE cart_id = '" . (int)$cart['cart_id'] . "'");
			/* Codinginspect Extension Ends */

			// The advantage of using $this->add is that it will check if the products already exist and increase the quantity if necessary.
			$this->add($cart['product_id'], $cart['quantity'], json_decode($cart['option'], true), $cart['subscription_plan_id']);
		}
	}
}`

I can do the changed in opencart 3x with OCMOD, but how to do in opencart 4x ?

[padaliyajay]

this solution of mine could help you in your requirements
#10251 (reply in thread)

[karan982]

Thank you for the suggestion, I will implement your solution. In case I will face any problem I will contact you. Your solution seems like promising.

[karan982]

@padaliyajay

I would like to say Thank you, Thank you for the solution you provided me.
This is the module I update module in opencart 4x with help of your solution.
https://www.opencart.com/index.php?route=marketplace/extension/info&extension_id=32001

Now I can convert my other extension that are dependent on cart library.

[padaliyajay]

@karan982

It is my pleasure to help. and glad to know it worked for you.

FYI. this is my theme, You can suggest it if someone looking for a theme
https://pocotheme.com/

[karan982]

@padaliyajay

of course I do. Thank you again.

[punitkumar]

Hi All,

I have Order Invoice PDF plugin, this plugin attach a PDF file to email whenever customer place a order.
same PDF file goes to admin alert email as well.

In OC3x

Scenario with OCMOD

File: catalog/controller/mail/order.php

Find: $mail->setTo($order_info['email']);
Add code: Before 

// Attach PDF invoice Starts
 $mail->addAttachment($file_pdf);
// Attach PDF invoice Ends

In OC4x
how the same can be achieved?

PS: I do not want to replicate the whole code that is use in

public function add(array $order_info, int $order_status_id, string $comment, bool $notify): void {

[padaliyajay]

Unfortunately there is no way in oc4 for mail. you will need to send additional mail by event for attachment

[punitkumar]

@mhcwebdesign

Do you have any solution for problem I described above?

[punitkumar]

That's why there is a requirement of fixed event triggers for libraries. Not sure if current object of particular can be capture in events action.

Sending two emails.. clients must avoid this way and developer is no way except modify core file!!

[cartbinder]

Is it possible to add code within the model function via events?

Example: I wish to add a product category filter on the product list page.
So this needs the getProducts function in the product.php(model) to have a filter_category rule.

If anyone can suggest or help.

[padaliyajay]

@padaliyajay getProducts function is using db class to run sql. so basically you need to wrap and overwrite db object in before event. later when $this->db->query will run inside a getproducts then first your wrapper function with run

if you don't know opencart and php properly then this will be hard for you to understand

[cartbinder]

Your last explanation was good. Got it now. Interesting !! Thank you !!

[padaliyajay]

Glad to know you understood it. you are welcome

[cartbinder]

@padaliyajay One more question If you know about this:

If there are internal calls Example: getProduct() called within getProducts() in admin/model/catalog/product.php
here there are no events fired for the getProduct function call. I tested this on 3.x version. Not on the 4.x version. But i think its the same. Events are not fired if the call is internal within the same file.

So is there any way to modify the getProduct() function via events?

[padaliyajay]

In OC3, event will not work
$this-> getProduct

In OC4, event will work
$this->model_catalog_product->getProduct

[TheCartpenter]

In regard to the $mail->addAttachment() issue, what we may need is a engine/mail class similarly designed like engine/config and engine/loader/language() altogether. This way, the $this->mail->send() would only be used once per action from the core and extension developers could add: $this->mail->addAttachment() before the $this->mail->send() completes its action.

While the mail engine may not reflect on mail extension engines to use the send() method, it already allows the use of additional email namespaces from the library as each mail namespaces can already be loaded independently from the library/mail's __construct() method.

Furthermore, since the events are already attached to the engine/loader, a mail() method could also be added in there to handle the $this->mail object.

[padaliyajay]

but there can be multiple mail to send. even you create list of mail then still hard to find correct mail to modify.

better option is to create model for mail as same like resize image model. and we can use event to modifty arguments

[padaliyajay]

$this->model_tool_mail->addMail([mail data]);

[TheCartpenter]

Based on the above solution, an array is now used in OC v4.x releases as a second parameter to be used with the mail engine that is currently with the library/mail which could also bring this solution to a next level by separating the library as an Engine class.

[TheCartpenter]

Using models for the emails still won't allow to integrate events in the model code since the $mail object will still be already executed by other extensions whereas the same actions per emails would be used rather than each actions between the instantiation of the mail engine and the mail send() method.

[TheCartpenter]

Right now, there are values that are instantiated from the system/config profiles with the email class by released extensions. Is it a suggested or recommended way to do it? Not, it's not. Is there another to do it, at this time without interfering with other extensions? No, there isn't. The system/framework.php file already fetches each system/config profiles independently also including the mail classes from all extensions that requires each mail engines to be loaded.

Just look at the codes, you'll have a better understanding.

[punitkumar]

I also don't understand @TheCartpenter point, until a proper solution is there what can be done for Opencart 4.0.2.1 ?

As @padaliyajay suggested to send a second email if there is any requirement to send attachment. Which I believe is the possible way.

[TheCartpenter]

Then keep waiting for it. A solution will come up later on for the next generation.

[punitkumar]

Then provide a working solution for a given problem.

[TheCartpenter]

It's all a matter of time. If it's a luxury you don't have, you can always email the programming team for custom projects or to download an extension from the OC Marketplace if you cannot develop it yourself.