Tech Huddle: January 10, 2024

[drodzewicz]

Topics to discuss

• (1) @kchelstowski Product Sources List Export Button
  https://pihemr.atlassian.net/browse/OBPIH-6025?focusedCommentId=149005

• (2) @drodzewicz Fix faulty organization data OBGM-753
  This ticket has been hanging there for a while needs some final decisions or actions, or move it out of the sprint and create a new one with requirements

  • comment from Manon on bug for duplicate location name validation - should probably create a separate ticket for it.
  • OBGM-753 Empty string validation on name and code of organization #4416 should this be merged a hotfix-1 for 9.0?
  • The most important thing about this was updating the database and updating or removing the faulty organization, Manon has updated 3 locations that were connected to that "nullish" organization on obnav, final actions should also be performed and that organization should be dealt with.

• (3) @drodzewicz How to handle API changes?
  Broader topic about dealing with API changes that change eg. the structure of the response. My case was when I was thinking of updating the comments field to additionalInformation. What is the right approach? API versioning?

• (4) @drodzewicz OBPIH-5826
  OBPIH-5826 comment indication approvals comment #4429 decided to go with a separate requsitionCommnet for a stockMovement item. In general the whole comments workflow needs some attention and redesign so this probably should be an alright solution for now.

• (5) @drodzewicz: OBPIH-6004 Invoice prepayment for partially shipped items
  needs attention (review) Katarzyna suggested not including these changes to a hotfix for 9.0 and instead include it in 9.1, which I agree since there a many cases that needs to be thoroughly tested to make sure everything works as expected

[drodzewicz]

Discussed

(2) The most important thing is fixing the data, the PR is not blocking/blocked by anything and is not critical.

(3) To Be Discussed

(4) @jmiranda will review the PR #4429 and decide if current changes are satisfactory for now. Further down the line we need to rethink the design of the whole comments workflow, how or if we should mash them all together in single list or have a different appraoch.

(5) This feature is getting pushed back from 0.9.0-hotfix-1 to potentially 0.9.1. The changes are too big and might not be implemented in the near future.