Tech Huddle: December 11, 2023

[jmiranda]

Attendees:
Manon, @jmiranda, @alannadolny, @drodzewicz, @kchelstowski, @awalkowiak

Discussed

• OBGM-137 OBGM-137 Remove checking if !hasExecutedAnyPreviousChangesets before … #4408
  • Missing some detection bits in the install / update database migration process
  • @awalkowiak to investigate and enumerate what's missing. We'll then either:
    • create a PR with error handling throw an error to prevent the issue
    • create a PR to actual handle the issue (changing the changelog versions method to be called prefixes and ignore install and views)
    • document in GH issues or 0.9.0 docs
• OBPIH-6008 any other params in map
  • Set deepValidate:false to default back when we were first starting the OBGM project because it was causing validation errors when saving POs because an organization had a role or a user with a role that did have a name. We've since added role.name but we have not re-enabled deepValidate as far as I know. I don't think we want to enable deepValidate but we can add a spike ticket to investigate the pros and cons.
  • At the moment, we just need to know whether deepValidate is enabled/disabled by default in Grails 1 and Grails 3.
  • Also check whether we are setting this config property explicit in application.yml (or somewhere else)
  • Once we find the product we should remove the product code and product name properties from the params map
  • Product name should also be removed from the params map once imported (look to see if the excel import plugin supports read-only)
    • Tech Debt: If there's no read-only mechanism we need to classify columns as read-only vs writable to prevent overwriting data we don't want to allow to be edited
  • In the mutual association code we want to instantiate the object and set the properties explicit (make sure we know what is being set on the object when using the params map so we know what all fields to set.
• OBGM-753 supplier location invalid organization data
  • Confirmed that this was a Rapidi issue so this is likely an OBS ticket to clean the data
    • We do not want to delete the record because there are locations that have been created with this org as Supplier
    • We can change the organization record to include id=0000, code="BAD", name="Bad Organization", active=false (if possible)
  • Spike: We are not going to do anything on the OBGM side right now because this requires more investigation into the proper handling
    • We should prevent lookup of organization with code = empty string
    • We should make sure that there's no way to insert a row into party that has an empty string for ID, code, name via GORM or the database
  • New Ticket: While reviewing this ticket we noticed the install/changelog.groovy had two issues to address @awalkowiak
    • id", type: "VARCHAR(255)
    • defaultValue: ""
    • defaultValue: "", name: "id"

Not Discussed

• OBGM-750 invoice item validation
• OBGM-745 dashboard config
• OBGM-149 Fix issues that came out during investigation of ajax tags #4403 Transactional annotation controller
• OBS-1602 Release 0.9.x Release to Community
• OBPIH-5973 0.9.x Release Plan
• OBGM-201 tech debt process