{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":140630477,"defaultBranch":"master","name":"phosphor-ipmi-flash","ownerLogin":"openbmc","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2018-07-11T21:44:07.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/13670043?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1714425510.0","currentOid":""},"activityList":{"items":[{"before":"deb85ceebe045cc14028febf94e0c358aeaef171","after":"3f5962877855937e32008aac96dd750d8264cd00","ref":"refs/heads/master","pushedAt":"2024-04-16T20:32:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"handler: Support more retry logic\n\nAdd retry logic for more methods that may fail due to unstable\nipmi interfaces. Also added one seconds sleep in between retries to\nallow some time for the interface to be initialized.\n\nTested: Updated BMC firmware with the new tool and didn't have any\nregression.\n\nChange-Id: Ifc4155dd895f1a654da9e03f17e4c1e8613c9133\nSigned-off-by: Willy Tu <wltu@google.com>","shortMessageHtmlLink":"handler: Support more retry logic"}},{"before":"a9423469ce218804587883989e0b2ebcdb47016b","after":"deb85ceebe045cc14028febf94e0c358aeaef171","ref":"refs/heads/master","pushedAt":"2023-12-07T22:03:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"meson: adjust nlohmann-json dependency\n\nSimplify the dependency logic and align wrap file directives with\nother repositories.\n\nSigned-off-by: Patrick Williams <patrick@stwcx.xyz>\nChange-Id: I61209bcd25995ef447c790e59ad717c1192acbc2","shortMessageHtmlLink":"meson: adjust nlohmann-json dependency"}},{"before":"2d57d522925560eef9ac9bc666db3dcf91a02cf7","after":"a9423469ce218804587883989e0b2ebcdb47016b","ref":"refs/heads/master","pushedAt":"2023-10-20T22:30:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"clang-format: copy latest and re-format\n\nclang-format-17 has some backwards incompatible changes that require\nadditional settings for best compatibility and re-running the formatter.\nCopy the latest .clang-format from the docs repository and reformat the\nrepository.\n\nChange-Id: Ie6154ef3394b8e652a8cb1ac33d68e3c3cec8cd8\nSigned-off-by: Patrick Williams <patrick@stwcx.xyz>","shortMessageHtmlLink":"clang-format: copy latest and re-format"}},{"before":"3d54fc7cb0c1e5b9acad046244894f88185e9a07","after":"2d57d522925560eef9ac9bc666db3dcf91a02cf7","ref":"refs/heads/master","pushedAt":"2023-09-21T05:46:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"tools/pci: refactor did variable for NuvotonPciBridge\n\nSymptom:\nHost tool \"burn_my_bmc\" for in-band firmware update didn't work\nand exception is about PCI device cannot find in NPCM8xx platform.\n\nroot@localhost:~#\nburn_my_bmc --command update --interface ipmipci --image test.sig\n--sig test.sig --type dummy\n\nSending over the firmware image.\nOpening the cleanup blob\nCommitting to the cleanup blob\nClosing cleanup blob\nException received: Couldn't find supported PCI device\n\nRoot cause:\nThere are new Nuvoton PCI device-id in NPCM8xx platform.\nThe previous device-id 0x0750 is hardcode for NPCM7xx platform.\nHowever, NPCM8xx PCI device is using new device-id 0x0850.\nThus, host tool will throw the exception from NotFoundException().\n\nSolution:\nWe need to refactor this \"did\" variable to make host tool\n\"burn_my_bmc\" can work well for these two kinds of PCI devices.\n\nTested:\nIn-band firmware update can work well in NPCM8xx with did change to 0x0850.\nHere is the result of \"lspci\" from host side for refer it.\nroot@localhost:~# lspci -v | grep d7:\nd7:01.0 Unassigned class [ff00]: Winbond Electronics Corp Device 0850 (rev 08)\nd7:02.0 Unassigned class [ff00]: Winbond Electronics Corp Device 0850 (rev 08)\n\nChange-Id: I2917298f13b0bcd7de3b2ff71173c546ea3cb02b\nSigned-off-by: Tim Lee <timlee660101@gmail.com>","shortMessageHtmlLink":"tools/pci: refactor did variable for NuvotonPciBridge"}},{"before":"8c31624dfc9599a3df663394a2faeedba3f0e397","after":"3d54fc7cb0c1e5b9acad046244894f88185e9a07","ref":"refs/heads/master","pushedAt":"2023-08-16T04:52:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"meson_options.txt: Support for reading options from meson.options\n\nSupport has been added for reading options from meson.options instead\nof meson_options.txt[1]. These are equivalent, but not using the .txt\nextension for a build file has a few advantages, chief among them\nmany tools and text editors expect a file with the .txt extension to\nbe plain text files, not build scripts.\n\n[1] https://mesonbuild.com/Release-notes-for-1-1-0.html#support-for-reading-options-from-mesonoptions\n\nSigned-off-by: George Liu <liuxiwei@inspur.com>\nChange-Id: I3393b174da5c6898d10c3948ecdd3e8875b77586","shortMessageHtmlLink":"meson_options.txt: Support for reading options from meson.options"}},{"before":"41dedad6e9a024ddaf14ab91e61e31183b7ac4aa","after":"8c31624dfc9599a3df663394a2faeedba3f0e397","ref":"refs/heads/master","pushedAt":"2023-07-17T14:59:34.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"README: remove stale reference to span-lite\n\nSigned-off-by: Patrick Williams <patrick@stwcx.xyz>\nChange-Id: I390f4abd653fa1e67f715fc39e2d4695ad18071a","shortMessageHtmlLink":"README: remove stale reference to span-lite"}},{"before":"4719ad0bd26067126a6cc1d0f20d5d8d1680993e","after":"41dedad6e9a024ddaf14ab91e61e31183b7ac4aa","ref":"refs/heads/master","pushedAt":"2023-07-14T00:16:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"use std::move_only_function\n\nC++23 has a replacement for function2 in std::move_only_function.\nLeverage that and remove the extra dependency.\n\nSigned-off-by: Patrick Williams <patrick@stwcx.xyz>\nChange-Id: I69fa59627b91fc1f640f7a688926bed7f138ca19","shortMessageHtmlLink":"use std::move_only_function"}},{"before":"1038836c25abccea9f7ba71b97f7a12938132ba4","after":"4719ad0bd26067126a6cc1d0f20d5d8d1680993e","ref":"refs/heads/master","pushedAt":"2023-07-13T00:15:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"build: upgrade to C++23\n\nMeson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of\nthe standard has been implemented.  Upgrade the build to leverage it.\n\nChange-Id: I2abf95de6076e750c086241161edefcd29f298a4\nSigned-off-by: Patrick Williams <patrick@stwcx.xyz>","shortMessageHtmlLink":"build: upgrade to C++23"}},{"before":"7fb9abd296ea5acad60ac3e28800a20905bc8724","after":"1038836c25abccea9f7ba71b97f7a12938132ba4","ref":"refs/heads/master","pushedAt":"2023-05-10T20:09:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"clang-format: copy latest and re-format\n\nclang-format-16 has some backwards incompatible changes that require\nadditional settings for best compatibility and re-running the formatter.\nCopy the latest .clang-format from the docs repository and reformat the\nrepository.\n\nChange-Id: I2ee8cbc4581d0c3ccdc130b646357c45fa0373db\nSigned-off-by: Patrick Williams <patrick@stwcx.xyz>","shortMessageHtmlLink":"clang-format: copy latest and re-format"}},{"before":"1b23b77285ae55eb570218f1d4634fb57aede5f0","after":"7fb9abd296ea5acad60ac3e28800a20905bc8724","ref":"refs/heads/master","pushedAt":"2023-04-12T19:16:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"meson: remove deprecated get_pkgconfig_variable\n\nSince meson 0.56, the `get_pkgconfig_variable` has been deprecated.  In\nmeson 0.58 the `get_variable` was enhanced to no longer require the\n`pkgconfig` keyword argument.  Ensure meson 0.58 is required and update\nthe usage of all `get_pkgconfig_variable` and `get_variable` to be the\nmodern variant.\n\nChange-Id: I9d6c273f740a62fdbea64cb29ae6db29b8af19da\nSigned-off-by: Patrick Williams <patrick@stwcx.xyz>","shortMessageHtmlLink":"meson: remove deprecated get_pkgconfig_variable"}},{"before":"64a23b26eac12d609f88f0550116a123dd738df6","after":"1b23b77285ae55eb570218f1d4634fb57aede5f0","ref":"refs/heads/master","pushedAt":"2023-03-15T22:51:17.639Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Add retry to sendFile handler\n\nIn cases where the ipmi interface is interrupted, we want to be able to\nrecover automatically without having to retrigger it again. For example,\nthis may happen if the ipminet interface gets reconfigure in the middle\nof transfering an image.\n\nThe inital goal was to have the retry for ipminet only with and restart\nat the remaining data instead of from the beginning. The issue there is\nthat we needed to restart the ipmi blob session to write again and doing\nso will clear out the existing written data. When trying to write to\nexisting session will caused the update to be stalled and required a\nipmi restart to recover.\n\nTested:\nimages is able to be tranfered fully and validated after we interrupted\nthe ipminet interface in the middle.\n\nChange-Id: Id734f6a92625bc6a1256fea010fb4b068f7bf1d5\nSigned-off-by: Willy Tu <wltu@google.com>","shortMessageHtmlLink":"Add retry to sendFile handler"}},{"before":"db45fd46f6caf1dd13b4a121e3b4e38eae51146a","after":"64a23b26eac12d609f88f0550116a123dd738df6","ref":"refs/heads/master","pushedAt":"2023-03-10T03:18:58.780Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Use 'type' of delete action in the log_handler builder\n\nThis was a bug where the 'type' of the open action was being used rather\nthan using the 'type' in the delete action config.\n\nTested:\n- Created LogHandler with the following config.\n```\n{\n    \"blob\": \"/log/log-blob-name\",\n    \"handler\": {\n       \"type\": \"file\",\n       \"path\": \"/var/run/log-blob-file.log\"\n    },\n    \"actions\": {\n        \"open\": {\n            \"type\": \"skip\"\n        },\n        \"delete\": {\n            \"type\": \"systemd\",\n            \"unit\": \"log-blob-delete.service\"\n        }\n},\n```\n- Checked log-blob-delete.service was run when blob was deleted\n\nChange-Id: I2e4c783d9b159ad269ef06721d872bb8052af81c\nSigned-off-by: Brennan Swanton <brennanswanton@google.com>","shortMessageHtmlLink":"Use 'type' of delete action in the log_handler builder"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEMmt0twA","startCursor":null,"endCursor":null}},"title":"Activity · openbmc/phosphor-ipmi-flash"}