{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":124975776,"defaultBranch":"master","name":"phosphor-host-postd","ownerLogin":"openbmc","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2018-03-13T01:46:24.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/13670043?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1714425483.0","currentOid":""},"activityList":{"items":[{"before":"72d550728d794dff5faa11ed0e57b98ebcb8d4d1","after":"95aa444074ec354485cce3d8c858ea05814d1fb9","ref":"refs/heads/master","pushedAt":"2024-04-08T16:35:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Change Aspeed PCC device name validation\n\nLatest Aspeed PCC driver adds dual node support.\nAspeed PCC devices are named as \"aspeed-lpc-pcc\".\n\nChange device name string check to substring check.\n\nTested on AMD CRB system.\n\nChange-Id: I486471bc28c2d6cd6fdcf5e7a115ba455f71003e\nSigned-off-by: Rajaganesh Rathinasabapathi ","shortMessageHtmlLink":"Change Aspeed PCC device name validation"}},{"before":"676fd83d14b19d98b3ccc37cd46c06f29edeba4f","after":"72d550728d794dff5faa11ed0e57b98ebcb8d4d1","ref":"refs/heads/master","pushedAt":"2024-04-02T21:33:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Add Aspeed PCC driver support\n\nAdd support for Aspeed Post Code Capture driver.\n\nIn order to fetch post code from Aspeed PCC driver, please set\n`snoop-device` and `post-code-bytes` as below.\n- snoop-device = aspeed-lpc-pcc\n- post-code-bytes = 8\n\nTested on Harma system.\n\nChange-Id: I5806362d2a54d1ed7b7f821d512f79cbc3effd38\nSigned-off-by: Cosmo Chou \nSigned-off-by: Potin Lai ","shortMessageHtmlLink":"Add Aspeed PCC driver support"}},{"before":"bebbda9b47a2d44b28d4bb8ef24d4bc9866064ed","after":"676fd83d14b19d98b3ccc37cd46c06f29edeba4f","ref":"refs/heads/master","pushedAt":"2023-12-01T15:18:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"build: use allowed over enabled\n\nMeson feature options are typically in a tri-state of enabled, disabled,\nor auto. The enabled and disabled functions on an option (from\n`get_option`) no longer return true for auto features. Instead, the\nexpectation is to use `allowed()` which is true for both enabled and auto.\n\nSwitch all uses of `enabled` to `allowed`.\n\nChange-Id: I1fb38a8715c8dbec883beaadd8519472de452e43\nSigned-off-by: Patrick Williams ","shortMessageHtmlLink":"build: use allowed over enabled"}},{"before":"de7a6dd79bfdd6c975bfb2bdce1a0af29539535f","after":"bebbda9b47a2d44b28d4bb8ef24d4bc9866064ed","ref":"refs/heads/master","pushedAt":"2023-10-21T15:14:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"clang-format: copy latest and re-format\n\nclang-format-17 has some backwards incompatible changes that require\nadditional settings for best compatibility and re-running the formatter.\nCopy the latest .clang-format from the docs repository and reformat the\nrepository.\n\nChange-Id: I9289bdced9919b505edbd70a0d1c41bc6abdee1e\nSigned-off-by: Patrick Williams ","shortMessageHtmlLink":"clang-format: copy latest and re-format"}},{"before":"0522592f862674381e1f1ac6448edb1b8b98922a","after":"de7a6dd79bfdd6c975bfb2bdce1a0af29539535f","ref":"refs/heads/master","pushedAt":"2023-08-30T20:54:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Separate IPMI and legacy snoop code to different files\n\nsnoopd contains two implementations that have very little in common.\nSeparate the IPMI code (functions and global objects) into its own file\nto reduce #ifdefs and make it easier to understand. Better separate the\ncmdline options and help text to only be used in the applicable build\nconfiguration.\n\nTested: Built with -Dsnoop=enabled and verified only -h option is\naccepted. Built without -Dsnoop and verified -d/-r/-b options are\naccepted.\n\nChange-Id: I7f14469fafd9f050f6b9f356882ce9e26fb7f206\nSigned-off-by: Jonathan Doman ","shortMessageHtmlLink":"Separate IPMI and legacy snoop code to different files"}},{"before":"42c2b56851c12ddc4cea22226ce5d628c02cdd7c","after":"0522592f862674381e1f1ac6448edb1b8b98922a","ref":"refs/heads/master","pushedAt":"2023-08-16T11:03:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"meson_options.txt: Support for reading options from meson.options\n\nSupport has been added for reading options from meson.options instead\nof meson_options.txt[1]. These are equivalent, but not using the .txt\nextension for a build file has a few advantages, chief among them\nmany tools and text editors expect a file with the .txt extension to\nbe plain text files, not build scripts.\n\n[1] https://mesonbuild.com/Release-notes-for-1-1-0.html#support-for-reading-options-from-mesonoptions\n\nSigned-off-by: George Liu \nChange-Id: If8cb9035eae5ef9008c0d13488817f2143920f02","shortMessageHtmlLink":"meson_options.txt: Support for reading options from meson.options"}},{"before":"0ea7357e6cc44c0340314165d4f50de0de48a6a6","after":"42c2b56851c12ddc4cea22226ce5d628c02cdd7c","ref":"refs/heads/master","pushedAt":"2023-07-12T17:20:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"build: upgrade to C++23\n\nMeson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of\nthe standard has been implemented. Upgrade the build to leverage it.\n\nChange-Id: Iba60434850d3f636a3a1a500fda8252b3b54e3a6\nSigned-off-by: Patrick Williams ","shortMessageHtmlLink":"build: upgrade to C++23"}},{"before":"fd2430d8d6691a41480656db8e1c2a8269a5ea25","after":"0ea7357e6cc44c0340314165d4f50de0de48a6a6","ref":"refs/heads/master","pushedAt":"2023-05-10T16:55:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"clang-format: copy latest and re-format\n\nclang-format-16 has some backwards incompatible changes that require\nadditional settings for best compatibility and re-running the formatter.\nCopy the latest .clang-format from the docs repository and reformat the\nrepository.\n\nChange-Id: I509c8567baedea7c86787f2e880900da13ebfc9f\nSigned-off-by: Patrick Williams ","shortMessageHtmlLink":"clang-format: copy latest and re-format"}},{"before":"38b0946cee9ec287dded7ce8cbb84bd445b44554","after":"fd2430d8d6691a41480656db8e1c2a8269a5ea25","ref":"refs/heads/master","pushedAt":"2023-05-03T19:23:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Put rate limiting options behind #ifdef\n\nFixes compile issue when ENABLE_IPMI_SNOOP is set (rateLimit var set but\nnot used).\n\nAlso add usage help text for --rate-limit option.\n\nTested: Compiles with IPMI snoop feature enabled and disabled.\n\nChange-Id: I13a7f6c4633577d24124667a428f047b657c0da1\nSigned-off-by: Jonathan Doman ","shortMessageHtmlLink":"Put rate limiting options behind #ifdef"}},{"before":"65d1753ca99624e9f6e8479b66a82764a75d4b88","after":"38b0946cee9ec287dded7ce8cbb84bd445b44554","ref":"refs/heads/master","pushedAt":"2023-05-03T16:16:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"Add rate limiting\n\nA host CPU can write POST codes much faster than the BMC can handle\nthem, considering all the D-Bus/IPC work required. Ideally `dbus-broker`\nwould apply backpressure when it gets full of unhandled signals, but its\nquota mechanism uses a simple per-user accounting that doesn't\ndifferentiate between all the connections from OpenBMC daemons running\nas root. So there is no way to configure it to prevent just `snoopd`\nfrom sending too many messages - instead it will disconnect arbitrary\nservices leading to mass chaos.\n\nSo without a D-Bus policy mechanism to prevent excess memory usage,\nthere are 2 different failure cases during a POST code storm:\n1. `snoopd` continues to send messages faster than `post-code-manager`\n can process them, leading to `dbus-broker` consuming all the system\n memory.\n2. `snoopd` fills up the D-Bus socket buffer. Once sd-bus fails to send\n a message across the socket, it starts queuing messages internally\n leading to `snoopd` consuming all the system memory. This only\n happens because we get stuck in the `snoopd` read loop during a POST\n code storm, and we don't process other events that would allow the\n write queue to drain.\n\nAs a workaround, introduce configurable rate limiting to `snoopd`. A new\nmeson option 'rate-limit' sets the corresponding '--rate-limit'\ncommand-line parameter. These options take an integer value representing\nthe maximum number of POST codes to process per second. The default\nmeson option value is 1000, and the value of 0 will disable rate limiting.\n\nTested: Ran the POST code stress on host for 30 minutes:\n```\n[root@sut ~]# stress-ng --ioport 2\n```\n\nWatched BMC process memory usage and CPU usage in `top`, verified that\n`post-code-manager`, `dbus-broker`, and `snoopd` each used less than 10%\nCPU and 2% memory on AST2600 with 512 MiB of DRAM.\n\nChange-Id: If03a01e0cd62366d188109bb4dff52958346e1db\nSigned-off-by: Jonathan Doman ","shortMessageHtmlLink":"Add rate limiting"}},{"before":"30751ec2595dc31441a29294a14c705cec9d0d5d","after":"65d1753ca99624e9f6e8479b66a82764a75d4b88","ref":"refs/heads/master","pushedAt":"2023-04-12T15:48:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"bradbishop","name":"Brad Bishop","path":"/bradbishop","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8423748?s=80&v=4"},"commit":{"message":"meson: remove deprecated get_pkgconfig_variable\n\nSince meson 0.56, the `get_pkgconfig_variable` has been deprecated. In\nmeson 0.58 the `get_variable` was enhanced to no longer require the\n`pkgconfig` keyword argument. Ensure meson 0.58 is required and update\nthe usage of all `get_pkgconfig_variable` and `get_variable` to be the\nmodern variant.\n\nChange-Id: I3f360e25af1da4b026e70cce65480641ebcac263\nSigned-off-by: Patrick Williams ","shortMessageHtmlLink":"meson: remove deprecated get_pkgconfig_variable"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEKyc4SQA","startCursor":null,"endCursor":null}},"title":"Activity ยท openbmc/phosphor-host-postd"}