{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":43011325,"defaultBranch":"master","name":"phosphor-host-ipmid","ownerLogin":"openbmc","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2015-09-23T15:57:29.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/13670043?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1714425461.0","currentOid":""},"activityList":{"items":[{"before":"337a0978efd615ef27ff1ba8241974a7c020d845","after":"e11895fd80d47fe24faaf04d9fe91e2ed206a214","ref":"refs/heads/master","pushedAt":"2024-04-23T22:00:06.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"geissonator","name":"Andrew Geissler","path":"/geissonator","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1612261?s=80&v=4"},"commit":{"message":"meson: Use boost as a dependency\n\nCurrently boost library is found via the 'cpp.find_library' call. With\nthis method local build of the project requires host to have the boost\nlibraries installed.\nSince the meson have a subproject system to download missing\ndependencies, rewrite boost requirement to a 'dependency' object. This\nway it would be possible to build the project locally on the system\nwithout the boost library installed.\n\nTested:\nBoth local meson build and Yocto build are performed successfully.\n\nChange-Id: I082aeb1d6c09627ea53f58cb6cd375f080401d57\nSigned-off-by: Konstantin Aladyshev ","shortMessageHtmlLink":"meson: Use boost as a dependency"}},{"before":"04b0b0799e8417c37024fc24787c2a9f28d8c0de","after":"337a0978efd615ef27ff1ba8241974a7c020d845","ref":"refs/heads/master","pushedAt":"2024-04-10T22:08:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"geissonator","name":"Andrew Geissler","path":"/geissonator","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1612261?s=80&v=4"},"commit":{"message":"chassis: Switch NMI handling to Control.Host.NMI interface\n\nNothing in mainline OpenBMC appears to implement a service for the\nChassis.Control.NMISource interface as far as I can tell, so 'ipmitool\nchassis power diag' had no way of working. With this change we switch\nipmid to use the same interface that bmcweb uses to handle a POST of\n'{\"ResetType\":\"Nmi\"}' to the ComputerSystem.Reset endpoint (which\nx86-power-control implements and thus actually works).\n\nTested: 'ipmitool chassis power diag' now successfully triggers an NMI\non the host via x86-power-control instead of simply logging an error on\nthe BMC.\n\nSigned-off-by: Zev Weiss \nChange-Id: Ic4c6cb2546cbd3877953fac9dd04ea752810c46c","shortMessageHtmlLink":"chassis: Switch NMI handling to Control.Host.NMI interface"}},{"before":"50f186c104bd7ac7293e737833b4443137ad2761","after":"04b0b0799e8417c37024fc24787c2a9f28d8c0de","ref":"refs/heads/master","pushedAt":"2024-04-03T22:30:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"geissonator","name":"Andrew Geissler","path":"/geissonator","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1612261?s=80&v=4"},"commit":{"message":"Enable reducing the number of sensors managed by IPMI\n\nIPMI is only able to support a finite amount of SDR records. Modern\nservers are capable of exceeding the number of sensors the IPMI\nspecification can support.\n\nThe change made in this commit filters sensors from a service based\nupon contents in a JSON configuration file.\n\nTested:\nConfirmed the default compile resulted in too many sensors being\ncreated.\nAdded the 'sensor_filter.json' file and confirmed the number of\nsensors was reduced, and 'ipmitool sdr list' no longer exhibited error\nmessages.\n\nChange-Id: I3643e06abbb8708d3f4000f35c79be8901e34057\nSigned-off-by: Johnathan Mantey ","shortMessageHtmlLink":"Enable reducing the number of sensors managed by IPMI"}},{"before":"1f42d1a70787bc06b0454ff1bb1fcf93dd097549","after":"50f186c104bd7ac7293e737833b4443137ad2761","ref":"refs/heads/master","pushedAt":"2024-03-15T01:00:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"geissonator","name":"Andrew Geissler","path":"/geissonator","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1612261?s=80&v=4"},"commit":{"message":"utils: Add the getSubTree method\n\nThe purpose of this patch is to prevent other methods from calling\nObjectMapper's `GetSubTree` property, but to obtain the correct the\nobjectTree values by calling the standard the getSubTree method.\n\nSigned-off-by: George Liu \nChange-Id: Ia719f92ca31fa75f83a7ffd07fdcb680bd4243b0","shortMessageHtmlLink":"utils: Add the getSubTree method"}},{"before":"863e3231d5bf302734741d99f65d12acf1313b1f","after":"1f42d1a70787bc06b0454ff1bb1fcf93dd097549","ref":"refs/heads/master","pushedAt":"2024-03-15T00:46:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"geissonator","name":"Andrew Geissler","path":"/geissonator","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1612261?s=80&v=4"},"commit":{"message":"user_mgmt: Fix incorrect log description\n\nThe entry method in log debug should be getManagedObjectsMethod\ninstead of getSubTree.\n\nSigned-off-by: George Liu \nChange-Id: I1dfdbd67412284f385466b56a67e86026ec97be1","shortMessageHtmlLink":"user_mgmt: Fix incorrect log description"}},{"before":"6fdce0a9c5798557170124b055cbdfd2ed4f5a00","after":"863e3231d5bf302734741d99f65d12acf1313b1f","ref":"refs/heads/master","pushedAt":"2024-03-15T00:25:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"geissonator","name":"Andrew Geissler","path":"/geissonator","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1612261?s=80&v=4"},"commit":{"message":"sensordatahandler: Remove unused method\n\nThe getServiceAndPath method is no longer used. This patch will\nremove this method.\n\nSigned-off-by: George Liu \nChange-Id: I8601c3bf4f67183c37de00b6914c0efb9a15491b","shortMessageHtmlLink":"sensordatahandler: Remove unused method"}},{"before":"e561d3ea345d77e281ada75b58f3153bbee66290","after":"6fdce0a9c5798557170124b055cbdfd2ed4f5a00","ref":"refs/heads/master","pushedAt":"2024-03-14T00:33:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"geissonator","name":"Andrew Geissler","path":"/geissonator","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1612261?s=80&v=4"},"commit":{"message":"settings: Remove unused methods\n\nThe setting method in setting.hpp is no longer used. This patch will\nremove this method.\n\nSigned-off-by: George Liu \nChange-Id: I00b1de0f4189dadf52e27772e4668782793e31ee","shortMessageHtmlLink":"settings: Remove unused methods"}},{"before":"d9eb721ef581c8968b1a7994b9ba4b1edb5a5c09","after":"e561d3ea345d77e281ada75b58f3153bbee66290","ref":"refs/heads/master","pushedAt":"2024-03-14T00:33:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"geissonator","name":"Andrew Geissler","path":"/geissonator","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1612261?s=80&v=4"},"commit":{"message":"chassishanlder: restorePolicy supports Unknown type\n\nThe PDI interface of RestorePolicy already supports None type [1],\nand ipmitool will resolve it to 0x03 by default. This commit is\nadding None type.\n\n[1] https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/yaml/xyz/openbmc_project/Control/Power/RestorePolicy.interface.yaml#L24\n\nTested: If the value of the PowerRestorePolicy attribute on DBus is\nequal to xyz.openbmc_project.Control.Power.RestorePolicy.Policy.None\n\n1. without this patch:\n~# ipmitool chassis status\nError sending Chassis Status command: Unspecified error\n\n2. with this patch:\n~# ipmitool chassis status\nSystem Power : off\nPower Overload : false\nPower Interlock : inactive\nMain Power Fault : false\nPower Control Fault : false\nPower Restore Policy : unknown\nLast Power Event :\nChassis Intrusion : inactive\nFront-Panel Lockout : inactive\nDrive Fault : false\nCooling/Fan Fault : false\nFront Panel Control : none\n\nSigned-off-by: George Liu \nChange-Id: I91ae1c40229c8646846443c0977685241f456838","shortMessageHtmlLink":"chassishanlder: restorePolicy supports Unknown type"}},{"before":"b99de182fa868d7adb07e95d4603706e31f84abd","after":"d9eb721ef581c8968b1a7994b9ba4b1edb5a5c09","ref":"refs/heads/master","pushedAt":"2024-03-14T00:32:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"geissonator","name":"Andrew Geissler","path":"/geissonator","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1612261?s=80&v=4"},"commit":{"message":"Remove libmapper dependency\n\nAfter this commit is merged [1], phosphor-ipmi-host no longer depends\non libmapper. This commit removes the dependence on libmapper.\n\n[1] https://gerrit.openbmc.org/c/openbmc/phosphor-host-ipmid/+/69082\n\nSigned-off-by: George Liu \nChange-Id: Iacf20716b3dd02f0c3173eb6c1fcb39d416f72a6","shortMessageHtmlLink":"Remove libmapper dependency"}},{"before":"f027bf0334b91de5c829d21082dd42b75b45a405","after":"b99de182fa868d7adb07e95d4603706e31f84abd","ref":"refs/heads/master","pushedAt":"2024-02-22T21:22:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"geissonator","name":"Andrew Geissler","path":"/geissonator","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1612261?s=80&v=4"},"commit":{"message":"Assign ASCII-Latin8 to dbus-sdr FRU string Type/Len\n\nThe FRU ID string Type/Len encoding in the dbus-sdr code is left\nunassigned, which causes it to be tagged as unicode characters. This\nis not the encoding of the data, which is actually ASCII/Latin8.\n\nThe problem appears to go unnoticed, I expect, because the dbus-sdr\nfunctionality is not enabled. When dbus-sdr is enabled the id-string\nsupplied to IPMITool is ASCII/Latin8, but IPMITool decodes it as\nunicode.\n\nTested:\nEnabled dbus-sdr features.\nUse 'ipmitool fru print'\nConfirm FRU id-strings print as ASCII/Latin8\n\nChange-Id: Ie6d936f6b5a0b0cd9ccd9adb68e46e1efbb9b2e5\nSigned-off-by: Johnathan Mantey ","shortMessageHtmlLink":"Assign ASCII-Latin8 to dbus-sdr FRU string Type/Len"}},{"before":"796e82405eaa3180d8f4f51fb075a4b62783d521","after":"f027bf0334b91de5c829d21082dd42b75b45a405","ref":"refs/heads/master","pushedAt":"2024-02-08T17:57:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"geissonator","name":"Andrew Geissler","path":"/geissonator","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1612261?s=80&v=4"},"commit":{"message":"Update RestrictionMode enum\n\nUpdate the RestrictionMode enum to incoming phosphor-dbus-interfaces\nchanges.\n\nChange-Id: Ia7a3c48a561501bd5bf07574d02cc63a47d82ef5\nSigned-off-by: Matt Simmering ","shortMessageHtmlLink":"Update RestrictionMode enum"}},{"before":"cfd7fa83d3b5ab7d85eecc4b461df70cccf5ff45","after":"796e82405eaa3180d8f4f51fb075a4b62783d521","ref":"refs/heads/master","pushedAt":"2024-02-04T02:21:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"geissonator","name":"Andrew Geissler","path":"/geissonator","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1612261?s=80&v=4"},"commit":{"message":"Change pack type from UINT8_C to uint8_t\n\nSee the stdint.h file:\n```\n\\# define UINT8_C(c) c\n\\# define UINT16_C(c) c\n\\# define UINT32_C(c) c ## U\n```\n\nThe UINT8_C is a macro, it will be replaced by the value of c.\nThe size of UINT8_C is 4 and the size of uint8_t is 1.\n\nTested:\n```\n1. send ipmi command on the serial port to get static IPv6 router prefix length.\n~# ipmitool raw 0x0c 0x02 0x01 0x43 0x00 0x00\n 11 00\n2. set static IPv6 router address on the bios setup and reboot bios check the\nresult of static IPv6 router prefix length.\nThe static IPv6 router address and prefix length can be successfully displayed\non the bios setup.\n```\n\nSigned-off-by: Jian Zhang \nChange-Id: I1320e466217d5a3db75a7b99545eed922b00b6e2","shortMessageHtmlLink":"Change pack type from UINT8_C to uint8_t"}},{"before":"a008871d66299801fde39036bef77da8e50dcf74","after":"cfd7fa83d3b5ab7d85eecc4b461df70cccf5ff45","ref":"refs/heads/master","pushedAt":"2024-02-04T00:12:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"geissonator","name":"Andrew Geissler","path":"/geissonator","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1612261?s=80&v=4"},"commit":{"message":"dcmi: Flexible support for dhcp dbus path\n\nSince dhcp4 and dhcp6 configurations will be added in the future [1],\nwhen calling ipmitool's dcmi get/set conf param command, all dhcp\npaths should be flexibly supported instead of hard-coding the dhcp\ndbus path.\n\n[1] https://gerrit.openbmc.org/c/openbmc/phosphor-networkd/+/63124\n\nSigned-off-by: George Liu \nChange-Id: I00662eb5d16d97aad9dd1fc715b17cff57723108","shortMessageHtmlLink":"dcmi: Flexible support for dhcp dbus path"}},{"before":"62e3ca80564c55a949be9e45aa22e4ce89e43463","after":"a008871d66299801fde39036bef77da8e50dcf74","ref":"refs/heads/master","pushedAt":"2024-02-04T00:11:29.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"geissonator","name":"Andrew Geissler","path":"/geissonator","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1612261?s=80&v=4"},"commit":{"message":"Remove the mapper_get_service method\n\nSince `mapper_get_service` is a tool and may need to be refactored\nin the future [1], this patch is to delete the use of\n`mapper_get_service` and use the GetObject method on the server side\ninstead.\n\n[1] https://gerrit.openbmc.org/c/openbmc/phosphor-objmgr/+/68965\n\nSigned-off-by: George Liu \nChange-Id: Ia365ab4aa359ab5f9a2850ed305b9088d4f485fb","shortMessageHtmlLink":"Remove the mapper_get_service method"}},{"before":"af762de51e47089d87be5a2839cb96ff6dd03321","after":"62e3ca80564c55a949be9e45aa22e4ce89e43463","ref":"refs/heads/master","pushedAt":"2024-02-02T21:12:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"geissonator","name":"Andrew Geissler","path":"/geissonator","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1612261?s=80&v=4"},"commit":{"message":"sdr-dbus: Reduce log spam on bitmap error\n\nRemove the log for out_of_range error for\ngetSensorNumberFromPath and getPathFromSensorNumber. Log only once at\nthe end of looping through the sensor tree instead of for every sensor.\n\nTested:\nThe spam of\n```\nbimap<>: invalid key\n```\nis now gone.\n\nChange-Id: Ifc22141cc5450b57ce272c46537240084d94d2aa\nSigned-off-by: Willy Tu ","shortMessageHtmlLink":"sdr-dbus: Reduce log spam on bitmap error"}},{"before":"0c96fdf819ec17a08516505ae478aa81c68c5435","after":"af762de51e47089d87be5a2839cb96ff6dd03321","ref":"refs/heads/master","pushedAt":"2024-02-02T19:49:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"geissonator","name":"Andrew Geissler","path":"/geissonator","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1612261?s=80&v=4"},"commit":{"message":"dcmi: correct return data of Get Configuration Parameter command\n\nWhen users call \"ipmitool dcmi get_conf_param\" command, ipmitool shows\nparamters are disabled or 0.\n```\n DHCP Discovery method :\n Management Controller ID String is disabled\n Vendor class identifier DCMI IANA and Vendor class-specific \\\n Informationa are disabled\n Initial timeout interval : 0 seconds\n Server contact timeout interval : 0 seconds\n Server contact retry interval : 0 seconds\n```\n\nThose information are incorrect. The root cause of this issue due to the\nGet DCMI Configuration Command only returns success value w/o parameter\ndata.\n\nThis commit adds parameter data to the response message.\n\nTested:\n 1. Get DCMI Configuration Parameter\n $ipmitool dcmi get_conf_param\n 2. Data are shown as below\n ```\n DHCP Discovery method :\n Management Controller ID String is enabled\n Vendor class identifier DCMI IANA and Vendor class-specific\n Informationa are disabled\n Initial timeout interval : 4 seconds\n Server contact timeout interval : 120 seconds\n Server contact retry interval : 64 seconds\n ```\n\nChange-Id: I0089993062c3c30792786b8e7f0f39f9507f93c3\nSigned-off-by: Thang Tran ","shortMessageHtmlLink":"dcmi: correct return data of Get Configuration Parameter command"}},{"before":"ba0da6b3a98cd00ef5477c9dc584e187f430b76e","after":"0c96fdf819ec17a08516505ae478aa81c68c5435","ref":"refs/heads/master","pushedAt":"2024-01-30T02:41:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"geissonator","name":"Andrew Geissler","path":"/geissonator","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1612261?s=80&v=4"},"commit":{"message":"BugFix: user name contains invalid characters\n\nThere is an typo in the policy \"[a-zA-z_]\" configuration.\nIt it should be \"[a-zA-Z_]\"\n\nTested: Create a username contains invalid characters like: ^, [, or ].\n\nBefore: invalid character can be added as username\nipmitool user list 1\nID Name Callin\n4 ^test true\n5 [test true\n7 ]test true\n8 _test true\n\nAfter: error will be returned once user name has invalid character.\nipmitool user set name 4 ^test4\nSet User Name command failed (user 4, name ^test4): Unspecified error\n\nChange-Id: I28a7f36f10b44b59909536214e6688c1895ac14f\nSigned-off-by: nichanghao.nch ","shortMessageHtmlLink":"BugFix: user name contains invalid characters"}},{"before":"833b7064891974a77e3d197e98bb64d5ca4ad61c","after":"ba0da6b3a98cd00ef5477c9dc584e187f430b76e","ref":"refs/heads/master","pushedAt":"2024-01-24T21:35:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"geissonator","name":"Andrew Geissler","path":"/geissonator","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1612261?s=80&v=4"},"commit":{"message":"softoff: fix use of deprecated sdbusplus type\n\nsdbusplus removed the `phosphor` namespace alias to `sdbusplus::Timer`.\nFix here to use the original type.\n\nSigned-off-by: Patrick Williams \nChange-Id: I73772df569aa6efb20e3647b205b8db55220a1f3","shortMessageHtmlLink":"softoff: fix use of deprecated sdbusplus type"}},{"before":"ea46f3ca61dd12b210a74cf78e464c78e0987a47","after":"833b7064891974a77e3d197e98bb64d5ca4ad61c","ref":"refs/heads/master","pushedAt":"2024-01-10T16:56:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"geissonator","name":"Andrew Geissler","path":"/geissonator","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1612261?s=80&v=4"},"commit":{"message":"build: use allowed over enabled\n\nMeson feature options are typically in a tri-state of enabled, disabled,\nor auto. The enabled and disabled functions on an option (from\n`get_option`) no longer return true for auto features. Instead, the\nexpectation is to use `allowed()` which is true for both enabled and auto.\n\nSwitch all uses of `enabled` to `allowed`.\n\nChange-Id: I114b084eb227d4a767e404c14e4f3a613a5b83d6\nSigned-off-by: Patrick Williams ","shortMessageHtmlLink":"build: use allowed over enabled"}},{"before":"95655220063735ae76262b5da5accf6463b9f5cc","after":"ea46f3ca61dd12b210a74cf78e464c78e0987a47","ref":"refs/heads/master","pushedAt":"2023-12-10T15:29:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"geissonator","name":"Andrew Geissler","path":"/geissonator","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1612261?s=80&v=4"},"commit":{"message":"ipmi fru device description from dbus property\n\ncurrently 'FRU Device Description' is retrieved via EM json decorator\n\"xyz.openbmc_project.Inventory.Decorator.I2CDevice\"\n\nwhich does not even pass the validator and is not present on any of\nthe upstream EM configs.\n\nThis patch provides the 'FRU Device Description' via FruDevice dbus\nproperties, if present.\n\nMultiple Properties are considereded in order.\n\nTested: with 2 Supermicro PSU. FRU Device Description shows up.\n\nChange-Id: I924d88b4a3a2406e2f0747b1965cb5f5b50fd096\nSigned-off-by: Alexander Hansen ","shortMessageHtmlLink":"ipmi fru device description from dbus property"}},{"before":"1075283267013364f30f5135ffefb772a24297d0","after":"95655220063735ae76262b5da5accf6463b9f5cc","ref":"refs/heads/master","pushedAt":"2023-12-09T08:04:34.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"geissonator","name":"Andrew Geissler","path":"/geissonator","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1612261?s=80&v=4"},"commit":{"message":"sdbusplus: avoid deprecated phosphor::Timer\n\nsdbusplus had an older type named `phosphor::Timer` which was\nrecently renamed to `sdbusplus::Timer`. Update the code to use\nthe new type alias.\n\nChange-Id: If69434b3a3639b8f97ab16cab5da4d70e3379cb2\nSigned-off-by: Patrick Williams ","shortMessageHtmlLink":"sdbusplus: avoid deprecated phosphor::Timer"}},{"before":"3dad826bd7f8c03cf7f742c7051c9fc537ca0c6d","after":"1075283267013364f30f5135ffefb772a24297d0","ref":"refs/heads/master","pushedAt":"2023-11-28T03:10:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"geissonator","name":"Andrew Geissler","path":"/geissonator","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1612261?s=80&v=4"},"commit":{"message":"apphandler: fix Set System Info command\n\nReturn proper error response for reserved data bytes\n\nas per the ipmi specification,Set System Info parameters\ntakes block of string data and the first byte indicates the\nencoding of the string. the bits[7:4] are reserved.\n\nstring data byte 1:\n[7:4] - reserved\n[3:0] - encoding\n0h = ASCII+Latin1\n1h = UTF-8\n2h = UNICODE\nall other = reserved.\n\nThis patch verifies if the reserveds bits\nare being used and return proper error response\n\ntested\n//Before Fix:\n1)Paramter 1\n ipmitool raw 0x06 0x58 0x01 0x00 0x03 0x0e 0x56 0x65 0x72 0x73 0x69 0x6f 0x6e 0x32 0x2e 0x31 0x32 0x33 0x34 0x35\n\n2)Parameter 2\nipmitool raw 0x06 0x58 0x02 0x00 0x03 0x0e 0x56 0x65 0x72 0x73 0x69 0x6f 0x6e 0x32 0x2e 0x31 0x32 0x33 0x34 0x35\n\n3)Parameter 3:\nipmitool raw 0x06 0x58 0x01 0x00 0x03 0x0e 0x56 0x65 0x72 0x73 0x69 0x6f 0x6e 0x32 0x2e 0x31 0x32 0x33 0x34 0x35\n\n//After Fix:\n1)Parameter 1\nipmitool raw 0x06 0x58 0x01 0x00 0x03 0x0e 0x56 0x65 0x72 0x73 0x69 0x6f 0x6e 0x32 0x2e 0x31 0x32 0x33 0x34 0x35\nUnable to send RAW command (channel=0x0 netfn=0x6 lun=0x0 cmd=0x58 rsp=0xcc): Invalid data field in request\n\n2)Parameter 2\nipmitool raw 0x06 0x58 0x02 0x00 0x03 0x0e 0x56 0x65 0x72 0x73 0x69 0x6f 0x6e 0x32 0x2e 0x31 0x32 0x33 0x34 0x35\nUnable to send RAW command (channel=0x0 netfn=0x6 lun=0x0 cmd=0x58 rsp=0xcc): Invalid data field in request\n\n3)Parameter 3:\nipmitool raw 0x06 0x58 0x01 0x00 0x03 0x0e 0x56 0x65 0x72 0x73 0x69 0x6f 0x6e 0x32 0x2e 0x31 0x32 0x33 0x34 0x35\nUnable to send RAW command (channel=0x0 netfn=0x6 lun=0x0 cmd=0x58 rsp=0xcc): Invalid data field in request\n\nChange-Id: I8ac2c582bfc9029dc01008bbd665603562a9f275\nSigned-off-by: krishnar4 ","shortMessageHtmlLink":"apphandler: fix Set System Info command"}},{"before":"b1416efa8d6d1a14a51bd0590f5a5cb6399a10cf","after":"3dad826bd7f8c03cf7f742c7051c9fc537ca0c6d","ref":"refs/heads/master","pushedAt":"2023-11-28T00:54:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"geissonator","name":"Andrew Geissler","path":"/geissonator","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1612261?s=80&v=4"},"commit":{"message":"dbus-sdr: support Get Temperature Readings command\n\nThis commit support Get Temperature Readings command in the\ndynamicsensor library.\n\nThe design follows teps:\n- Get the list of sensors based on Entity Id\n- Sort the list of sensors.\n- Loop all of sensors in the list, if its Entity Instance is greater\nthan the Instance Start then read the temperature via object path.\n\nTested:\n 1. Request to read Temperature of sensors\n \"ipmitool dcmi get_temp_reading\"\n 2. Display Entity Id, Entity Instance, Temperature of sensors\n\nChange-Id: Iaa7d65a763dacb50c1488d2a161b180fed49899b\nSigned-off-by: Thang Tran ","shortMessageHtmlLink":"dbus-sdr: support Get Temperature Readings command"}},{"before":"7bb412f5a37ff3587a67610c022d781525b1a423","after":"b1416efa8d6d1a14a51bd0590f5a5cb6399a10cf","ref":"refs/heads/master","pushedAt":"2023-11-28T00:48:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"geissonator","name":"Andrew Geissler","path":"/geissonator","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1612261?s=80&v=4"},"commit":{"message":"dbus-sdr: check instance start value in getSensorInfo function\n\nIssue: When users request to read DCMI sensor information via \"ipmitool\nraw 0x2c 0x07 0xdc 0x01 0x07 0x00 \", the return values\nalways are 8 first sensors even the \"Instance_start\" is not 0.\n\nRoot cause: In the getSensorInfo function, it does not check the\ninstance start parameter. It always returns 8 first sensors.\n\nSolution: Update the getSensorInfo function as below:\n- Get the list of Sensors based on the Entity ID.\n- Sort the list of Sensors.\n- Compare Sensor's Entity Instance with Instance start parameter\n\nTested:\n 1. Get the list of DCMI sensors information with Instance start\n is not 0\n \"ipmitool raw 0x2c 0x07 0xdc 0x01 0x07 0x00 \"\n 2. BMC returns sensor Record ID which have the Entity Instance\n are greater than Instance start.\n\nChange-Id: I10f7cf4e87cb5eb8fe1da81561263e1604418c45\nSigned-off-by: Thang Tran ","shortMessageHtmlLink":"dbus-sdr: check instance start value in getSensorInfo function"}},{"before":"65362f497de12394305e2321f4433cc95c2e94ca","after":"7bb412f5a37ff3587a67610c022d781525b1a423","ref":"refs/heads/master","pushedAt":"2023-11-24T04:46:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"geissonator","name":"Andrew Geissler","path":"/geissonator","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1612261?s=80&v=4"},"commit":{"message":"dbus-sdr: sel: Fix dst setting\n\nUse the day time saving information on the system to calculate the time\ninstead of zero (no dst) as the default.\n\nhttps://linux.die.net/man/3/mktime\n\nFailure Example,\n```\n$ stat /var/log/ipmi_sel\n File: /var/log/ipmi_sel\n Size: 88 Blocks: 8 IO Block: 4096 regular file\nDevice: 1bh/27d Inode: 4125 Links: 1\nAccess: (0644/-rw-r--r--) Uid: ( 0/ root) Gid: ( 0/ root)\nAccess: 2023-09-25 14:37:03.631424968 -0700\nModify: 2023-09-25 14:37:02.291422780 -0700\nChange: 2023-09-25 14:37:02.291422780 -0700\n\n$ ipmitool sel\nSEL Information\nVersion : 1.5 (v1.5, v2 compliant)\nEntries : 0\nFree Space : 65535 bytes or more\nPercent Used : unknown\nLast Add Time : 09/25/23 14:30:08 PDT\nLast Del Time : Not Available\nOverflow : false\nSupported Cmds : 'Reserve'\n\n$ ipmitool sel list\n 1 | 09/25/23 | 15:30:07 PDT | reserved #0xff | | Asserted\n```\n\nTested:\nFixed the timezone issues\n```\n$ ipmitool sel list\n 1 | 09/25/23 | 14:30:07 PDT | reserved #0xff | | Asserted\n```\n\nChange-Id: I23bdb5039bed8e135f06d399a5e970bbc1e5ed58\nSigned-off-by: Willy Tu ","shortMessageHtmlLink":"dbus-sdr: sel: Fix dst setting"}},{"before":"68d9d40530351e3f3db2c00a25969b0efc9fbe3f","after":"65362f497de12394305e2321f4433cc95c2e94ca","ref":"refs/heads/master","pushedAt":"2023-11-24T00:41:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"geissonator","name":"Andrew Geissler","path":"/geissonator","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1612261?s=80&v=4"},"commit":{"message":"Watchdog: Add watchdog LogTimeout property setting function\n\nAdd function to set LogTimeout property to implement the function of\nthe watchdog not recording logs.\n\nTested:\nNo log bit is set to true :\nipmitool raw 0x06 0x24 0x84 0x00 0x00 0x3e 0x64 0x00\n\nNo log bit is set to false :\nipmitool raw 0x06 0x24 0x04 0x00 0x00 0x3e 0x64 0x00\n\nReset watchdog timer :\nipmitool mc watchdog reset\n\nIf the LogTimeout property is true, the event will be logged\non watchdog expiration.\nWe can use 'ipmitool sel elist' to check the system event log.\n1 | 01/26/23 | 00:21:21 PST | Watchdog2 host0 | Timer expired | Asserted\n\nIf the LogTimeout property is false, the event will not be\nlogged when the watchdog expires.\n\nRelated-Commit-Id: 66240\nRelated-Commit-Id: 67727\n\nChange-Id: I9cf9a294be7f584760dc03efaab02384f17e4686\nSigned-off-by: Tim Chao ","shortMessageHtmlLink":"Watchdog: Add watchdog LogTimeout property setting function"}},{"before":"e70c59b8761480daf57e3be962f5f36cc9dfcbfa","after":"68d9d40530351e3f3db2c00a25969b0efc9fbe3f","ref":"refs/heads/master","pushedAt":"2023-11-21T16:59:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"geissonator","name":"Andrew Geissler","path":"/geissonator","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1612261?s=80&v=4"},"commit":{"message":"Update terminology used within repo\n\nUpdate the terms to more inclusive language. This change if only for\nvariables used in the repo.\n\nChange-Id: I5151c9c2efab707b5dbc707e55333a3cb8c4e32b\nSigned-off-by: Matt Simmering ","shortMessageHtmlLink":"Update terminology used within repo"}},{"before":"e4aa654547b1dbac084843ac2c2ca8adf61478f7","after":"e70c59b8761480daf57e3be962f5f36cc9dfcbfa","ref":"refs/heads/master","pushedAt":"2023-11-16T02:35:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"geissonator","name":"Andrew Geissler","path":"/geissonator","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1612261?s=80&v=4"},"commit":{"message":"dbus-sdr: support reading OEM SEL logs\n\nThis commit supports reading OEM SEL record type in range 0xC0-0xDF and\n0xE0-0xFF.\n\nTested:\n Request to show SEL logs, OEM SEL log is shown.\n\nChange-Id: I8e2d2d84143c79cb7e3575c3f713d2b3ad2aaaf7\nSigned-off-by: Thang Tran ","shortMessageHtmlLink":"dbus-sdr: support reading OEM SEL logs"}},{"before":"3771f5f2e9f40d06e8377490ccf9630c86537b0a","after":"e4aa654547b1dbac084843ac2c2ca8adf61478f7","ref":"refs/heads/master","pushedAt":"2023-11-14T19:17:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"geissonator","name":"Andrew Geissler","path":"/geissonator","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1612261?s=80&v=4"},"commit":{"message":"Rewrite Read Event Buffer to use new API\n\nLots of hard-coded values in this one, but one value did get replaced\nwith a lookup. The output matches previous output with the one exception\nthat now the current manufacturer is used instead of a hard-coded value.\n\nTested: run ipmitool raw 6 0x35 and check the output\n Before:\n ipmitool raw 6 0x35\n 55 55 c0 41 a7 00 00 00 00 00 3a ff 00 ff ff ff\n After:\n ipmitool raw 6 0x35\n 55 55 c0 57 01 00 00 00 00 00 3a ff 00 ff ff ff\n\nSigned-off-by: Vernon Mauery \nChange-Id: I4910d8ee07db6f24d639f9322a0246e10a0260e3","shortMessageHtmlLink":"Rewrite Read Event Buffer to use new API"}},{"before":"1214d6cc51cbbde74b0b2b486cf161af6b616d65","after":"3771f5f2e9f40d06e8377490ccf9630c86537b0a","ref":"refs/heads/master","pushedAt":"2023-11-10T09:18:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"geissonator","name":"Andrew Geissler","path":"/geissonator","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1612261?s=80&v=4"},"commit":{"message":"Fix the bugs found in static analysis\n\nThis commit fixes the following static analyzer reported issues:\n\nOperands don't affect result\n some conditions are not required to check as its always true\nUnsigned compared against 0\nUnchecked return value from library\nUninitialized scalar variable\n\nChange-Id: I0b1fd426794bb88f6eafcc817cef5dd2f655e1ba\nSigned-off-by: PavanKumarIntel ","shortMessageHtmlLink":"Fix the bugs found in static analysis"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEOIjkgAA","startCursor":null,"endCursor":null}},"title":"Activity ยท openbmc/phosphor-host-ipmid"}