Revert "Remove Server Side Consistent Tokens (SSCTs)" #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1f2635c. As discussed on #openbao-general, this breaks existing migrations: anyone with SSCT tokens present in token store would lose all existing tokens and need to re-auth everything. This is moderately more disruptive for root tokens in particular, as `operator generate-root` would need to be taken (and sometimes these root tokens are stored but not used, as they don't necessarily expire). This reasonably breaks the "drop-in migration" guarantees of a Raft storage backend, and thus will be reverted for the time being. Other than the protobuf regeneration (which makes sense as it is an auto-generated file anyways), this was a clean revert. Resolves: openbao#297 Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1f2635c. As discussed on #openbao-general, this breaks existing migrations: anyone with SSCT tokens present in token store would lose all existing tokens and need to re-auth everything. This is moderately more disruptive for root tokens in particular, as
operator generate-rootwould need to be taken (and sometimes these root tokens are stored but not used, as they don't necessarily expire).This reasonably breaks the "drop-in migration" guarantees of a Raft storage backend, and thus will be reverted for the time being.
Other than the protobuf regeneration (which makes sense as it is an auto-generated file anyways), this was a clean revert.
Resolves: #297