Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure OSCP response is signed by correct issuer #266

Open
JanMa opened this issue Apr 4, 2024 · 4 comments
Open

Ensure OSCP response is signed by correct issuer #266

JanMa opened this issue Apr 4, 2024 · 4 comments
Assignees
@DanGhita
Labels
bug Something isn't working

Comments

@JanMa
Copy link
Contributor

JanMa commented Apr 4, 2024

This has been fixed in Vault 1.14.10 and we should fix it as well.
@JanMa JanMa added the bug Something isn't working label Apr 4, 2024
@cipherboy
Copy link
Contributor

See also https://discuss.hashicorp.com/t/hcsec-2024-07-vault-tls-cert-auth-method-did-not-correctly-validate-ocsp-responses/64573

@DanGhita
Copy link
Contributor

Hello all,

I can take this bug, if you want.
@naphelps , if no objection, could you assign me this bug ?

Thanks!

@cipherboy
Copy link
Contributor

cipherboy commented Apr 11, 2024 •
edited

@DanGhita This is rather complicated; let's chat about this one online sometime. I have a reproducer, and while I conceptually know the fix, fixing this doesn't really accomplish much, IMHO. I think the OCSP ecosystem needs additional changes.

Mind sending me an email and we can decide on times?

@DanGhita
Copy link
Contributor

OK @cipherboy , no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanGhita DanGhita

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cipherboy @JanMa @DanGhita