Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if @BeforeEach annotation is properly defined in TestWithSharedSparkSession and sub-classes #1365

Open
marekhorst opened this issue Jun 29, 2022 · 0 comments

Comments

@marekhorst
Copy link
Member

Originally reported by @mpol in #1361 (comment).

I guess it might be some leftover when the IIS test code base was switched from junit4 to junit5 as it seems the @BeforeEach default behavior has changed.

Nevertheless we should take a closer look and check if this "double indication" (by annotation in both super and sub classes and referencing with super()) in a sub-class method) of methods to be called before each test is really required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant