Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using report file location as a metric help in metrics exporter #1335

Open
marekhorst opened this issue Apr 1, 2022 · 1 comment
Open

Comments

@marekhorst
Copy link
Member

Originally reported on redmine: https://support.openaire.eu/issues/7666

Apparently using report file location as a metric help:

$ http localhost:9091/metrics|grep processing_citationTextExtraction_docs
# HELP processing_citationTextExtraction_docs location:/user/dnet.beta/iis/working_dirs/primary/report
# TYPE processing_citationTextExtraction_docs gauge
processing_citationTextExtraction_docs{instance="",job="iis",user="dnet.beta"} 1.0487217e+07
processing_citationTextExtraction_docs{instance="",job="iis",user="dnet.production"} 8.202193e+06

is problematic because the following entries are produced in the pushgateway logs:

Mar 31 11:49:46 prometheus pushgateway[27192](https://support.openaire.eu/issues/7666#fn27192): {"caller":"diskmetricstore.go:165","err":"Metric families have inconsistent help strings. The latter will have priority. This is bad. Fix your pushed metrics!","level":"info","msg":"metric families inconsistent help strings","new":"name:\"processing_citationTextExtraction_docs\" help:\"location:/user/dnet.production/iis/working_dirs/primary/report\" type:GAUGE metric:\u003clabel:\u003cname:\"instance\" value:\"\" \u003e label:\u003cname:\"job\" value:\"iis\" \u003e label:\u003cname:\"user\" value:\"dnet.production\" \u003e gauge:\u003cvalue:8.202193e+06 \u003e \u003e ","old":"name:\"processing_citationTextExtraction_docs\" help:\"location:/user/dnet.beta/iis/working_dirs/primary/report\" type:GAUGE metric:\u003clabel:\u003cname:\"instance\" value:\"\" \u003e label:\u003cname:\"job\" value:\"iis\" \u003e label:\u003cname:\"user\" value:\"dnet.beta\" \u003e gauge:\u003cvalue:1.0487217e+07 \u003e \u003e ","ts":"2022-03-31T09:49:46.301Z"}
Mar 31 11:49:46 prometheus pushgateway[27192](https://support.openaire.eu/issues/7666#fn27192): {"caller":"diskmetricstore.go:165","err":"Metric families have inconsistent help strings. The latter will have priority. This is bad. Fix your pushed metrics!","level":"info","msg":"metric families inconsistent help strings","new":"name:\"processing_referenceExtraction_softwareUrl_duration_seconds\" help:\"location:/user/dnet.production/iis/working_dirs/primary/report\" type:GAUGE metric:\u003clabel:\u003cname:\"instance\" value:\"\" \u003e label:\u003cname:\"job\" value:\"iis\" \u003e label:\u003cname:\"user\" value:\"dnet.production\" \u003e gauge:\u003cvalue:9130 \u003e \u003e ","old":"name:\"processing_referenceExtraction_softwareUrl_duration_seconds\" help:\"location:/user/dnet.beta/iis/working_dirs/primary/report\" type:GAUGE metric:\u003clabel:\u003cname:\"instance\" value:\"\" \u003e label:\u003cname:\"job\" value:\"iis\" \u003e label:\u003cname:\"user\" value:\"dnet.beta\" \u003e gauge:\u003cvalue:8386 \u003e \u003e ","ts":"2022-03-31T09:49:46.301Z"}
@mpol
Copy link
Contributor

mpol commented Apr 1, 2022

Additionally it would be confusing to anybody ever looking at the help (maybe in Grafana) to see a path related to eg. dnet.beta with a metric related to dnet.production (or the other way around). Although in practice I guess nobody ever looks at the help anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants