Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate .rubocop_todo.yml when rubocop is updated with Depfu #5009

Open
dmarcoux opened this issue May 22, 2018 · 2 comments · May be fixed by #16058
Open

Regenerate .rubocop_todo.yml when rubocop is updated with Depfu #5009

dmarcoux opened this issue May 22, 2018 · 2 comments · May be fixed by #16058
Labels
depfu PRs from our dependency update bot Feature Frontend Things related to the OBS RoR app

Comments

@dmarcoux
Copy link
Contributor

dmarcoux commented May 22, 2018

Is your feature request related to a problem? Please describe.
With Depfu, rubocop is updated frequently and with these updates, the file .rubocop_todo.yml has to be regenerated since cops are often added/deleted/changed. We need to remember about regenerating this file. This can be sometimes forgotten.

Describe the solution you'd like
I would like that the CI regenerates the file .rubocop_todo.yml, so that it cannot be forgotten before the pull request is merged. In CircleCI, it is possible to have conditional jobs. With these, we can easily trigger the regeneration of the file .rubocop_todo.yml for the Depfu pull requests updating rubocop.

Describe alternatives you've considered
I contacted Depfu to ask them if it is possible to do this upstream and they told me that it isn't.

Additional context
Here's a link to the documentation for the conditional jobs

@Ana06
Copy link
Member

Ana06 commented Jun 18, 2018

@dmarcoux

I contacted Depfu to ask them if it is possible to do this upstream and they told me that it isn't.

me too: depfu/feedback#15 😂 and what they suggest is basically your solution:

One way to maybe solve it would be to configure your CI to run that script based on the branch name (which are very specific for Depfu updates)

@Ana06 Ana06 added Frontend Things related to the OBS RoR app depfu PRs from our dependency update bot labels Jun 18, 2018
@Ana06 Ana06 self-assigned this Jun 18, 2018
@dmarcoux
Copy link
Contributor Author

dmarcoux commented Aug 6, 2018

Changing this from Travis CI to CircleCI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depfu PRs from our dependency update bot Feature Frontend Things related to the OBS RoR app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants