Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel flushing cannot rely on dirty checks #1616

Open
franzpoeschel opened this issue Apr 26, 2024 · 0 comments · May be fixed by #1619
Open

Parallel flushing cannot rely on dirty checks #1616

franzpoeschel opened this issue Apr 26, 2024 · 0 comments · May be fixed by #1619
Labels
api: breaking breaking API changes api: new additions to the API bug MPI

Comments

@franzpoeschel
Copy link
Contributor

Describe the bug
Currently, our flushing logic checks iterations if they are dirty, i.e. have any data that needs to be flushed, and flushes them only then. This does not work reliably in parallel since even an independent write must be flushed collectively.

To Reproduce
No need for a reproducer, the reason for the behavior is known.

Expected behavior
Since we are currently moving towards improving our support for more general Iteration::open()/Iteration::close() workflows, our flushing logic should flush exactly those Iterations that are currently open instead of trying to outsmart the user by just flushing what we think needs to be flushed.
Until then, an intermediate solution would be to expose sth like Iteration::markDirty().

Additional context
Found by @psychocoderHPC

@franzpoeschel franzpoeschel added bug api: breaking breaking API changes MPI api: new additions to the API labels Apr 26, 2024
@franzpoeschel franzpoeschel linked a pull request May 8, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: breaking breaking API changes api: new additions to the API bug MPI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant