Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Machine selector generates many SRAM file not found messages #1584

Closed
grauw opened this issue Feb 19, 2024 · 4 comments
Closed

Machine selector generates many SRAM file not found messages #1584

grauw opened this issue Feb 19, 2024 · 4 comments

Comments

@grauw
Copy link
Contributor

grauw commented Feb 19, 2024

When using the machine selector UI I get a ton of "SRAM file not found" complaints in the message log, which pops up again and again after I close it as I continue browsing the machines. Seems these are generated as a result of the query for the machine information tooltip.

May want to clear out the SRAM files from your ~/.openMSX directory to reproduce that, since it seems to only occur once for every machine and then creates the SRAM file in my user dir.

Using Github actions build openmsx-19.1-571-ge11842aaa-mac-aarch64-bin.dmg.zip

@MBilderbeek
Copy link
Member

Yes, this happens because the machines are actually instantiated. A similar thing is that for the extensions in some cases large files are created (e.g. empty HD images). But that doesn't give a pop-up I guess.

@m9710797 wouldn't it be better to make something to avoid this when we only want to instantiate for some queries?

@m9710797
Copy link
Contributor

I agree. I'll put this on my TODO list.

@m9710797
Copy link
Contributor

With a one-line change I could suppress the messages (revision 92a8dca).
However the SRAM files (typically for the RTC) and HD images are still being created.

  • On the one hand that's fine. That also tests that those files really can be created (e.g. the directory is writable). And SRAM files don't take much space.
  • On the other hand, empty HD images are also created. These are 100MB. Nowadays that's not a whole lot, but also not negligible.

@grauw
Copy link
Contributor Author

grauw commented May 20, 2024

Messages were previously silenced in 92a8dca, and now the “SRAM file not found, assuming blank content” message has also been removed altogether in f1bbc93.

@grauw grauw closed this as completed May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants