Inability to navigate the memory using the keyboard

[theNestruo]

• Windows version: 10.0.19045.3754
• OpenMSX version: 19.1-467-g993c367c0 [Release]

Steps to reproduce:

1. Open OpenMSX, open the memory window
2. Click on the memory window so it gets the focus
3. Try to navigate through the memory using keys: up, down, left, right, home, end, PgUp, PgDown

Current behaviour:

4. Up, down, left and right navigate byte by byte through the window. Home is ignored. End acts as right key. PgUp and PgDown are ignored.

Expected behaviour:

4. Up, down, left and right navigate byte by byte through the window. Home and end move to the beginning/end of the line. Ctrl+Home/Ctrl+End move to the beginning/end of the window. PgUp and PgDown scroll a page in the memory window. Basically, the standard (i.e.: expected) behaviour of those keys in almost any text/hexadecimal viewer/editor.

Expected behaviour (bonus):

5. Ctrl+Up/Ctrl+Down scroll a line in the memory window. Not every text/hexadecimal viewer/editor does it, but it is a common behaviour.

[m9710797]

Thanks. Absolutely valid feedback. I'll implement it, though with lower priority.

The reason for this is that this hex-viewer is a 3rd-party widget. We do have the source code for it, so we could modify it (but that makes upgrading to a newer version more difficult). But let's first focus on improving our own code.

[ocornut]

The memory editor (published at https://github.com/ocornut/imgui_club) is rather old code (2017), I sort of maintained and tweaked but honestly I was surprised to see it used by so many projects.

I would be totally open to do a fuller refresh of its codebase given dear imgui has evolved a lot since then, and I tend to agree it would be good to have better keyboard control. While I can't promise any timely result, opening an issue in imgui_club would be adequate as I'm perfectly open to have those in the main lib.

[MBilderbeek]

Note that PgUp/PgDn are not ignored in the latest code. But it seems when changing from PgUp to PgDn, the first 'other direction button' is ignored. A bit odd.