Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key binding should be contextual #1559

Open
theNestruo opened this issue Nov 19, 2023 · 2 comments
Open

Key binding should be contextual #1559

theNestruo opened this issue Nov 19, 2023 · 2 comments
Labels
imgui Issues related to the Dear ImGui functionality

Comments

@theNestruo
Copy link

theNestruo commented Nov 19, 2023

  • Windows version: 10.0.19045.3754
  • OpenMSX version: 19.1-467-g993c367c0 [Release]

Steps to reproduce:

  1. Open OpenMSX and load any game
  2. Open the disassembly window
  3. Click on the disassembly window
  4. Navigate through the code using keys up, down, Home, End, PgUp, PgDown

Current behaviour:

  1. Keys trigger navigation actions (right), but also emulator actions (wrong). E.g.: PgUp and PgDown are also trigger the reverse/replay feature

Expected behaviour:

  1. Any key event that is handle by a window should be consumed and not passed to the main window
@MBilderbeek MBilderbeek added the imgui Issues related to the Dear ImGui functionality label Nov 22, 2023
@ocornut
Copy link

ocornut commented Feb 8, 2024

Hello, dear imgui author here.

Technically openMSX could query the focus state of e.g. game window to decide to pipe inputs solely to it. But I believe there are many situation where it would be desirable to manipulate controls while toying with tools, and no simple single-change will full-fill all need.

The input-aware/key ownership system, and input routing system (via e.g. high-level functions like Shortcut()) can accommodate for many things but it's not a trivial system and poorly documented. If an openMSX author wants to have a video-call/conversation about those someday I'm open to it.

@MBilderbeek
Copy link
Member

@theNestruo can you please confirm that this is fixed in the latest development build? (We indeed improved input routing, thanks to @pvmm .)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imgui Issues related to the Dear ImGui functionality
Projects
None yet
Development

No branches or pull requests

3 participants