Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugging 'logger' into printerport fails unless the file from printerlogfilename already exists #1549

Open
MBilderbeek opened this issue Nov 4, 2023 · 3 comments

Comments

@MBilderbeek
Copy link
Member

If you want to plug the logger into the printer port, the file that is in the printerlogfilename must already exist (by default printer.log in the current directory), otherwise you get an error: plug: plug failed: Couldn't plug printer logger: printer.log not found in this context

@m9710797
Copy link
Contributor

m9710797 commented Nov 6, 2023

Can you in PrinterPortLogger.cc:43, try changing "File::TRUNCATE" to "File::CREATE"?

BTW this has always(?) been like this, so this feature never properly worked. And people (i mean non-openMSX developers) never complained. Maybe that's a good indication that it's not needed to add this in ImGui? (Not everything that's possible in openMSX should be exposed in the GUI).

@MBilderbeek
Copy link
Member Author

It cannot always have been like this, because I never manually created the log file and it was there already. Same for BiFi who initially reported this issue.

@MBilderbeek
Copy link
Member Author

I tried changing to CREATE, but that doesn't help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants