Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter extension is outdated #740

Closed
benz0li opened this issue Feb 9, 2024 · 23 comments
Closed

Jupyter extension is outdated #740

benz0li opened this issue Feb 9, 2024 · 23 comments

Comments

@benz0li
Copy link

benz0li commented Feb 9, 2024

Outdated (MS marketplace > Open VSX version)

  1. ms-toolsai.jupyter (installs: 74.787M, daysInBetween: -150): 2024.1.1 > 2023.9.100

See also https://github.com/open-vsx/publish-extensions/actions/runs/7839191547

@benz0li
Copy link
Author

benz0li commented Feb 9, 2024

@filiptronicek 2024.1.1 – v2024.1.1 to be precise – corresponds to https://github.com/microsoft/vscode-jupyter/tags.

@benz0li
Copy link
Author

benz0li commented Feb 9, 2024

@amvanbaren Has the long-term viability of https://open-vsx.org [as intended by the Open VSX Working Group] been secured?

@filiptronicek
Copy link
Collaborator

Thanks for the report, @benz0li. I will take a look into what's wrong with Jupyter this time.

What already seems to have changed since last time is that the Microsoft Marketplace now offers platform-specific releases for Jupyter, which we should also have in ovsx.

@filiptronicek
Copy link
Collaborator

Raised a discussion about platform-specific releases.
microsoft/vscode-jupyter#15183

For now, I will most likely release a universal package which should work nonetheless and is at least up-to-date.
ms-toolsai-jupyter-insiders.vsix.zip

@benz0li
Copy link
Author

benz0li commented Apr 22, 2024

@filiptronicek Any update on this?

@filiptronicek
Copy link
Collaborator

I have manually bumped Jupyter to 2024.5.0

https://open-vsx.org/extension/ms-toolsai/jupyter

cc @benz0li

@benz0li
Copy link
Author

benz0li commented Apr 29, 2024

I have manually bumped Jupyter to 2024.5.0

@filiptronicek Thank you!

The current version of VS Code (1.88) supports up to Jupyter extension v2024.3.1.

I assume Jupyter extension v2024.5.0 will be supported by the next version of VS Code (1.89), which will be released by the end of this week.

@benz0li
Copy link
Author

benz0li commented Apr 29, 2024

IMHO no need to also provide v2024.3.1 on Open VSX.

@filiptronicek
Copy link
Collaborator

@benz0li you're absolutely right, me publishing May's version was a mistake by accidentally building from main. I published v2024.3.1 now as well so both should be covered.

@benz0li
Copy link
Author

benz0li commented Apr 29, 2024

@benz0li you're absolutely right, me publishing May's version was a mistake by accidentally building from main. I published v2024.3.1 now as well so both should be covered.

I get the following error now:

Installing extension 'ms-toolsai.jupyter'...
error parent:178 Uncaught exception: Invalid comment length. Expected: 63. Found: 0. Are there extra bytes at the end of the file? Or is the end of central dir signature `PK☺☻` in the comment?
error parent:178 Invalid: Invalid comment length. Expected: 63. Found: 0. Are there extra bytes at the end of the file? Or is the end of central dir signature `PK☺☻` in the comment?

@wjandrea
Copy link

wjandrea commented Apr 30, 2024

I get the following error now:

Installing extension 'ms-toolsai.jupyter'...
error parent:178 Uncaught exception: Invalid comment length. Expected: 63. Found: 0. Are there extra bytes at the end of the file? Or is the end of central dir signature `PK☺☻` in the comment?
error parent:178 Invalid: Invalid comment length. Expected: 63. Found: 0. Are there extra bytes at the end of the file? Or is the end of central dir signature `PK☺☻` in the comment?

I'm getting similar errors (using Install from VSIX...):

v2024.3.1
Invalid comment length. Expected: 63. Found: 0. Are there extra bytes at the end of the file? Or is the end of central dir signature `PK☺☻` in the comment?

v2024.5.0
Invalid comment length. Expected: 65. Found: 0. Are there extra bytes at the end of the file? Or is the end of central dir signature `PK☺☻` in the comment?

I tried uninstalling and reinstalling the extension, but no luck. I had to revert to v2023.9.100.

If it's relevant, I noticed that the two VSIXs aren't valid ZIP files, unlike all the others I have. file just says "data".

@cosing
Copy link

cosing commented Apr 30, 2024

I noticed some strange bytes appearing in the header and at the end of the file.
example:ms-toolsai.jupyter-2024.3.1.vsix
image

image

I use imhex to remove them,this file can be opened as a zip now,and install,it works.

I'm not sure what consequences this will have, but at least it looks like the installation was successful.

@filiptronicek
Copy link
Collaborator

filiptronicek commented Apr 30, 2024

Thank you all for the reports. This seems to be because of an issue when publishing, since the vsix I built for release seems to install fine. If you'd like to install that manually, I uploaded it below. I also raised EclipseFdn/open-vsx.org#2537, which should help us with re-uploading and fixing this.

ms-toolsai-jupyter-insiders.vsix.zip

@benz0li
Copy link
Author

benz0li commented Apr 30, 2024

Thank you all for the reports. This seems to be because of an issue when publishing, since the vsix I built for release seems to install fine. If you'd like to install that manually, I uploaded it below. I also raised EclipseFdn/open-vsx.org#2537, which should help us with re-uploading and fixing this.

@filiptronicek Why do you zip the VSIX again? These files are in fact already zip files.

I.e. with [the unzipped] ms-toolsai.jupyter-2024.3.1.vsix.zip I cannot change the file suffix from .vsix to .zip and unzip.
ℹ️ This works perfectly fine with ms-toolsai.jupyter-2023.9.100.vsix.

@filiptronicek
Copy link
Collaborator

@benz0li I hope it should be as easy as unzipping the attached file, because GitHub does not let you upload vsix files directly, I had to double zip 🙏

image

@benz0li
Copy link
Author

benz0li commented Apr 30, 2024

@filiptronicek #740 (comment) is still valid.

👉 There is something wrong with the VSIX file.

@benz0li
Copy link
Author

benz0li commented Apr 30, 2024

To reproduce:

  1. Unzip ms-toolsai.jupyter-2024.3.1.vsix.zip
  2. Rename ms-toolsai.jupyter-2024.3.1.vsix to ms-toolsai.jupyter-2024.3.1.zip
  3. Try unzipping ms-toolsai.jupyter-2024.3.1.zip

This is supposed to work, but it does not.

@filiptronicek
Copy link
Collaborator

@benz0li of course it does not work, because I accidentally uploaded the file from open-vsx.org I was comparing it with 🤦. I updated the comment with the correct one, which I made sure you can unzip.

@benz0li
Copy link
Author

benz0li commented Apr 30, 2024

I updated the comment with the correct one, which I made sure you can unzip.

I can confirm that it works now.

@filiptronicek
Copy link
Collaborator

We have removed the faulty versions and replaced v2024.3.1 with a correct package. I will publish v2024.5.0 when it actually becomes stable.

@benz0li
Copy link
Author

benz0li commented May 3, 2024

Code - OSS v1.89.0 was released yesterday: https://github.com/microsoft/vscode/releases/tag/1.89.0

@filiptronicek Could you please publish v2024.4.0 of the Jupyter extension?
ℹ️ That is the latest version compatible with Code - OSS v1.89.

Thank you for all the hard work.

@filiptronicek
Copy link
Collaborator

@filiptronicek Could you please publish v2024.4.0 of the Jupyter extension?

@benz0li I have just published the extension @ v2024.4.0 and fixed the build script to publish new releases automatically and correctly. I will continue to look into how we can provide platform-specific releases via this repo next.

@benz0li
Copy link
Author

benz0li commented Jun 4, 2024

Thank you @filiptronicek.

@benz0li benz0li closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants