Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrumentation support selector #2744

Open
crossoverJie opened this issue Mar 11, 2024 · 3 comments · May be fixed by #2778
Open

Instrumentation support selector #2744

crossoverJie opened this issue Mar 11, 2024 · 3 comments · May be fixed by #2778
Labels
area:auto-instrumentation Issues for auto-instrumentation discuss-at-sig This issue or PR should be discussed at the next SIG meeting enhancement New feature or request

Comments

@crossoverJie
Copy link
Contributor

Component(s)

auto-instrumentation

Is your feature request related to a problem? Please describe.

Instrumentation applies to the specified Pod, similar to this:
https://skywalking.apache.org/docs/skywalking-swck/latest/java-agent-injector/#1-label-selector-and-container-matcher

Describe the solution you'd like

apiVersion: opentelemetry.io/v1alpha1
kind: Instrumentation
metadata:
  name: my-instrumentation
spec:
  selector:
    app: appname

Describe alternatives you've considered

No response

Additional context

No response
@crossoverJie crossoverJie added enhancement New feature or request needs triage labels Mar 11, 2024
@pavolloffay pavolloffay added area:auto-instrumentation Issues for auto-instrumentation and removed needs triage labels Mar 11, 2024
@pavolloffay
Copy link
Member

This approach has one considerable downside over the annotation. The annotation changes pod spec, therefore it triggers re-deployment which is needed by the OTEL operator to inject the auto-instrumentation (the operator uses pod mutating webhook)

@crossoverJie
Copy link
Contributor Author

therefore it triggers re-deployment which is needed by the OTEL operator to inject the auto-instrumentation (the operator uses pod mutating webhook)

Yeah, you're right.

However, we hope that all the configurations associated with OTel can be handed over to Operator, and if the annotation are used, we also need to maintain them ourselves during the deployment.

@crossoverJie
Copy link
Contributor Author

This is our usage scenario; I'll submit a PR if appropriate.

apiVersion: opentelemetry.io/v1alpha1
kind: Instrumentation
metadata:
  name: my-instrumentation
spec:
  selector:
    app: appname
  propagators:
    - tracecontext
  java:
    image: image

@crossoverJie crossoverJie linked a pull request Mar 22, 2024 that will close this issue
Open
@jaronoff97 jaronoff97 added the discuss-at-sig This issue or PR should be discussed at the next SIG meeting label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:auto-instrumentation Issues for auto-instrumentation discuss-at-sig This issue or PR should be discussed at the next SIG meeting enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Instrumentations support select crossoverJie/opentelemetry-operator
3 participants
@pavolloffay @jaronoff97 @crossoverJie