Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching dependency bot to renovate #5271

Closed
2 tasks done
XSAM opened this issue Apr 26, 2024 · 12 comments · Fixed by open-telemetry/opentelemetry-go-contrib#5577
Closed
2 tasks done

Switching dependency bot to renovate #5271

XSAM opened this issue Apr 26, 2024 · 12 comments · Fixed by open-telemetry/opentelemetry-go-contrib#5577
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@XSAM
Copy link
Member

XSAM commented Apr 26, 2024

Problem Statement

Proposed Solution

Switch to renovate

Additional Context

#5244 (comment)

Tasks

@pellared
Copy link
Member

pellared commented May 6, 2024

This config can be used as a reference: https://github.com/signalfx/splunk-otel-go/blob/main/renovate.json

  • this also bumps indirect dependencies (except build directory)
  • runs go mod tidy
  • ensures that all folders are checked (e.g. test are excluded by default)

e.g.

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "extends": [
    "config:recommended"
  ],
  "ignorePaths": [],
  "separateMajorMinor": true,
  "postUpdateOptions" : [
    "gomodTidy"
  ],
  "packageRules": [
    {
      "matchManagers": ["gomod"],
      "matchDepTypes": ["indirect"],
      "enabled": true
    },
    {
      "matchFileNames": ["internal/tools/**"],
      "matchManagers": ["gomod"],
      "matchDepTypes": ["indirect"],
      "enabled": false
    }
  ]
}

@MrAlias
Copy link
Contributor

MrAlias commented May 6, 2024

This should be unblocked: open-telemetry/community#2090 (comment)

@pellared
Copy link
Member

pellared commented May 6, 2024

@XSAM, I updated open-telemetry/opentelemetry-go-contrib#4579

@XSAM
Copy link
Member Author

XSAM commented May 6, 2024

I don't know why this repo didn't receive any Configure Renovate PR.

@XSAM
Copy link
Member Author

XSAM commented May 6, 2024

FYI, the default config file looks like this

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "extends": [
    "config:recommended"
  ]
}

@pellared
Copy link
Member

pellared commented May 6, 2024

FYI, the default config file looks like this

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "extends": [
    "config:recommended"
  ]
}

I know but I want to at least make sure that go mod tidy is run and test Go modules are not ignored.

@XSAM
Copy link
Member Author

XSAM commented May 6, 2024

The renovate bot failed to create Renovate PR because it got a 422 Error from GitHub. https://developer.mend.io/github/open-telemetry/opentelemetry-go/-/job/817ca928-01ff-4038-a171-0296c06ab5ad

@pellared
Copy link
Member

pellared commented May 6, 2024

@MrAlias
Copy link
Contributor

MrAlias commented May 8, 2024

To resolve this, is the plan to rip out all the dependabot tooling and disable the bot on the repo?

@XSAM
Copy link
Member Author

XSAM commented May 9, 2024

To resolve this, is the plan to rip out all the dependabot tooling and disable the bot on the repo?

Recap the discussion at the meeting, we will disable dependabot for version updates, but keep the vulnerability alerts.

@MrAlias
Copy link
Contributor

MrAlias commented May 13, 2024

Are there any more tasks for this? Can this be closed?

@XSAM
Copy link
Member Author

XSAM commented May 14, 2024

I will prepare a PR for contrib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants