Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide what to do w/ mapstructure library #9161

Closed
codeboten opened this issue Dec 20, 2023 · 5 comments · Fixed by #9635
Closed

Decide what to do w/ mapstructure library #9161

codeboten opened this issue Dec 20, 2023 · 5 comments · Fixed by #9635
Labels
area:config area:confmap release:required-for-ga Must be resolved before GA release
Milestone
go.opentelemetry....

Comments

@codeboten
Copy link
Contributor

The library is going to be deprecated and a few options for existing forks are coming up. Should we move to another fork, fork it ourselves?

See mitchellh/mapstructure#349
@codeboten
Copy link
Contributor Author

One of the options for existing forks: https://github.com/go-viper/mapstructure

@mx-psi
Copy link
Member

mx-psi commented Dec 20, 2023

Trying to get #6671 fixed upstream and seeing how it goes could be a good test to see how receptive the new owners are to our use case

@atoulme atoulme mentioned this issue Feb 24, 2024
Merged
@atoulme
Copy link
Contributor

atoulme commented Feb 26, 2024

I am offering that we switch over to the fork which will be maintained moving forward: #9634

dmitryax pushed a commit that referenced this issue Feb 27, 2024
@atoulme
[confmap] use github.com/go-viper/mapstructure/v2 (#9634)
62beec3 
**Description:**
Update mapstructure to use a maintained fork,
github.com/go-viper/mapstructure/v2.
See mitchellh/mapstructure#349 for context

**Link to tracking Issue:**
#9161 

Creating this as WIP to see if all tests pass.
@TylerHelmuth
Copy link
Member

Since we've taking the forked version can we close this issue?

@mx-psi mx-psi linked a pull request Mar 1, 2024 that will close this issue
[confmap] confmap honors Unmarshal methods on config embedded structs. #9635
Merged
@mx-psi
Copy link
Member

mx-psi commented Mar 1, 2024

Will close it once we merge #9635, which fixes one of the things we were considering when tackling this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:config area:confmap release:required-for-ga Must be resolved before GA release
Projects
Collector: v1
Status: Done
Milestone
go.opentelemetry.io/collector/confmap...
4 participants
@atoulme @codeboten @mx-psi @TylerHelmuth