Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: find a way to remove native-tls from our dependency chain #16

Open
2 tasks done
jpmcb opened this issue Aug 3, 2023 · 0 comments
Open
2 tasks done

Feature: find a way to remove native-tls from our dependency chain #16

jpmcb opened this issue Aug 3, 2023 · 0 comments

Comments

@jpmcb
Copy link
Member

jpmcb commented Aug 3, 2023

Type of feature

πŸ• Feature

Current behavior

Ideally we wouldn't be consuming openssl through the native-tls chain of dependencies:

❯ cargo tree -i native-tls
native-tls v0.2.11
β”œβ”€β”€ hyper-tls v0.5.0
β”‚   └── reqwest v0.11.18
β”‚       β”œβ”€β”€ cached-path v0.6.1
β”‚       β”‚   └── tokenizers v0.13.3
β”‚       β”‚       └── open-sauced-repo-query v0.1.0 (/Users/jpmcb/workspace/opensauced/repo-query)
β”‚       β”œβ”€β”€ open-sauced-repo-query v0.1.0 (/Users/jpmcb/workspace/opensauced/repo-query)
β”‚       β”œβ”€β”€ openai-api-rs v0.1.11
β”‚       β”‚   └── open-sauced-repo-query v0.1.0 (/Users/jpmcb/workspace/opensauced/repo-query)
β”‚       β”œβ”€β”€ qdrant-client v1.3.0
β”‚       β”‚   └── open-sauced-repo-query v0.1.0 (/Users/jpmcb/workspace/opensauced/repo-query)
β”‚       └── tokenizers v0.13.3 (*)
β”œβ”€β”€ reqwest v0.11.18 (*)
└── tokio-native-tls v0.3.1
    β”œβ”€β”€ hyper-tls v0.5.0 (*)
    └── reqwest v0.11.18 (*)

But it looks like a there are some upstream changes that would need to be made in order to flip them to using rustls (or at least enable a feature that can use rustls-tls instead of native-tls)

Suggested solution

We'd need to upstream some changes to those libraries that are deep in our rust dependencies.

And this shouldn't be a priority until we consider adding TLS for requests to the repo-query engine. More just noting this for myself and others to be aware of.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@jpmcb jpmcb mentioned this issue Aug 22, 2023
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant