Replies: 3 comments 4 replies
-
Would suggest changing story book dark mode to a theming implementation like in their docs - with a select dropdown; then we would have 3 working dark mode implementations across all our systems we could debate over with a visual feedback system. Think we should enable more than 2 themes: light, dark, contrast, impaired and adaptive; leaning away from the docusaurus switch and react-dark-mode like 2way switches in general 😵 |
Beta Was this translation helpful? Give feedback.
-
Only thing I really ran into with storybook dark mode was there was a trick to make it so theme stayed constant between canvases - I think I had to feed it a default maybe? That may work fine with what you mentioned but we def wouldn't be using the storybook dark mode UI component anymore (hence not the plug-in) |
Beta Was this translation helpful? Give feedback.
-
Fwiw: https://mobile.twitter.com/kentcdodds/status/1415491278008033280 |
Beta Was this translation helpful? Give feedback.
-
During stream on 7/13 (around 32mins), Brian pointed out dark mode switch in Docusaurus, as something worth exploring working into Open Sauced.
Currently dark mode theme context is tri-state ("system", "light", "dark"). Read more here. This would involve dropping the "system" state and always being either "dark" or light. Before user makes a change initial setting would be based on system preference. After that, you'd persist preference to local storage. Just off the top of my head, pros and cons would be:
Pro:
Cons:
So ultimately the question is, do we need to follow system preference, other than determining state prior to the user switching it?
Beta Was this translation helpful? Give feedback.
All reactions