Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update intro.md #188

Merged
merged 2 commits into from
May 17, 2024
Merged

fix: Update intro.md #188

merged 2 commits into from
May 17, 2024

Conversation

georgepence
Copy link
Contributor

@georgepence georgepence commented May 13, 2024

Eliminate extraneous '>' from 2nd paragraph of "Prerequisites". (replace "starting> this course" with "starting this course").

Description

This PR removes an extraneous '>', an apparent typo, from the 2nd paragraph of "Prerequisites"

Related Tickets & Documents

Fixes #192

Mobile & Desktop Screenshots/Recordings

Original (branch main):

p2

PR will fix to display:

p1

Steps to QA

QA process:

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

Eliminate extraneous '>'  from 2nd paragraph of "Prerequisites". ("starting> this course" --> "starting this course").
@georgepence georgepence requested a review from a team as a code owner May 13, 2024 12:45
Copy link

netlify bot commented May 13, 2024

Deploy Preview for sauced-intro ready!

Name Link
🔨 Latest commit 15bc84c
🔍 Latest deploy log https://app.netlify.com/sites/sauced-intro/deploys/6643a01603c6710008c1df22
😎 Deploy Preview https://deploy-preview-188--sauced-intro.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @georgepence,

Thank you for your contribution! ✨

However, please read our contributing guidelines.

  • You need to work on existing issue or open a new issue that we've triaged before you work on your changes. That said, please create an issue and link it to your PR template.
  • Please complete the PR template. It's very important for us to be able to review your changes.

I will put this PR on draft for now. Please let me know once you've addressed above suggestions, I'll change this PR back for ready to review.

Thank you! 🙂

@adiati98 adiati98 marked this pull request as draft May 13, 2024 13:06
@adiati98
Copy link
Member

Hey @georgepence,

You now have an issue to accompany this PR (#192).

Please comment on the issue with .take to assign yourself to the issue and address my previous review before I can mark this as ready for review. 🙂

FYI, if the issue is not assigned, it's considered open for anyone to work on.

@adiati98 adiati98 removed their assignment May 15, 2024
@adiati98
Copy link
Member

adiati98 commented May 15, 2024

@georgepence I see that you've assigned yourself to the issue. 👏🏼

Now, you still need to complete the PR template. You can read this section in our course to do so.

I make this PR to ready for review so you can address each failed check in the checks below.
You can read this blog post to address PR checks failed.

Thanks.

@adiati98 adiati98 marked this pull request as ready for review May 15, 2024 17:23
@georgepence georgepence changed the title Update intro.md fix:Update intro.md May 15, 2024
@georgepence georgepence changed the title fix:Update intro.md fix: Update intro.md May 15, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@georgepence
Copy link
Contributor Author

Please review changes.

@adiati98
Copy link
Member

@georgepence you still have a check that needs to be addressed here.

@georgepence georgepence requested a review from adiati98 May 16, 2024 06:57
Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done and thank you for your contribution, @georgepence! ✨

If you haven't, you can join our community Discord.
Also, check out our pizza-verse repo if you want to contribute further! 🍕🍴

git merge GIF

@adiati98 adiati98 requested a review from BekahHW May 16, 2024 09:43
@adiati98 adiati98 merged commit b943a3c into open-sauced:main May 17, 2024
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Typographical error in English version
3 participants