Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: refactor Contributors grid view #3363

Open
zeucapua opened this issue May 10, 2024 · 1 comment
Open

Feature: refactor Contributors grid view #3363

zeucapua opened this issue May 10, 2024 · 1 comment
Assignees
Labels
chore label to mark dependency and documentation updates 💡 feature 👀 needs triage

Comments

@zeucapua
Copy link
Contributor

zeucapua commented May 10, 2024

Suggested solution

The Contributors component used in /explore, /workspaces/<id>/contributor-insights, and the upcoming /s/<org>/<repo>/contributors page has two views, "list" and "grid". The "grid" view is 3 components deep, with redundant hook calling. "List" (aka table) view will be refactored in another issue.

Needed for #3342

Visualized below:

  • Orange: components that call hooks
  • Light Red: functions that wrap a hook
  • Blue: hook (using useSWR to fetch the API)
  • Yellow: Component snippet (doesn't call hooks and has their own file)
    • Note: these components aren't used outside of the Contributors component scope
shapes at 24-05-09 21 16 43
Copy link

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please reach out to us on Discord or follow up on the issue itself.

For full info on how to contribute, please check out our contributors guide.

@zeucapua zeucapua added the LWI lunch week issue label May 10, 2024
@zeucapua zeucapua added chore label to mark dependency and documentation updates and removed LWI lunch week issue labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore label to mark dependency and documentation updates 💡 feature 👀 needs triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant