Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update card for Lunch Week #3344

Closed
BekahHW opened this issue May 8, 2024 · 5 comments · Fixed by #3439
Closed

Update card for Lunch Week #3344

BekahHW opened this issue May 8, 2024 · 5 comments · Fixed by #3439
Assignees

Comments

@BekahHW
Copy link
Member

BekahHW commented May 8, 2024

Once we have the lunch week page up, we should update this card to preview and link to the page.

Current

image

Suggestion

We just need the image for this (@isabensusan)

image
@BekahHW BekahHW added the LWI lunch week issue label May 8, 2024
@BekahHW BekahHW self-assigned this May 8, 2024
Copy link

github-actions bot commented May 8, 2024

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please reach out to us on Discord or follow up on the issue itself.

For full info on how to contribute, please check out our contributors guide.

@nickytonline
Copy link
Member

This will require updating the end to end test again.

await expect(page.getByRole("complementary", { name: "Introducing Star Search!", exact: true })).toBeVisible();

-  await expect(page.getByRole("complementary", { name: "Introducing Star Search!", exact: true })).toBeVisible();
+  await expect(page.getByRole("complementary", { name: "Join Our Lunch Week!", exact: true })).toBeVisible();

@BekahHW
Copy link
Member Author

BekahHW commented May 8, 2024 via email

Copy link

open-sauced bot commented May 21, 2024

🎉 This issue has been resolved in version 2.30.0-beta.10 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

open-sauced bot commented May 21, 2024

🎉 This issue has been resolved in version 2.30.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@open-sauced open-sauced bot added the released label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants