Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo pages show closed PRs, but they should be Merged #3338

Closed
bdougie opened this issue May 8, 2024 · 4 comments
Closed

Repo pages show closed PRs, but they should be Merged #3338

bdougie opened this issue May 8, 2024 · 4 comments
Labels
core team work Work that the OpenSauced core team takes on repo-pages

Comments

@bdougie
Copy link
Member

bdougie commented May 8, 2024

Screenshot 2024-05-07 at 4 24 52 PM

Looking at these charts. Issues closed should be a red line. PRs closed should be "merged."

cc @zeucapua & @isabensusan perhaps this is a quick fix?

@bdougie bdougie added core team work Work that the OpenSauced core team takes on repo-pages labels May 8, 2024
Copy link

github-actions bot commented May 8, 2024

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please reach out to us on Discord or follow up on the issue itself.

For full info on how to contribute, please check out our contributors guide.

@isabensusan
Copy link
Member

@bdougie agree on the "merged" wording for PRs, but for issues, GitHub consistently uses purple to represent "closed" issues, not red (I think the only place they showed it that way was on org insights). Might be missing something though, so let me know!

image

@bdougie
Copy link
Member Author

bdougie commented May 8, 2024

GitHub consistently uses purple to represent "closed" issues, not red (I think the only place they showed it that way was on org insights). Might be missing something though, so let me know!

We can go with github on closed issues. Related, I think "low activity" should be grey instead of red. Red sends the wrong signal.

@nickytonline
Copy link
Member

That's a good point about low @bdougie. We should also update OG images in regards to low activity as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core team work Work that the OpenSauced core team takes on repo-pages
Projects
None yet
Development

No branches or pull requests

3 participants