Bug: Can keep typing in the bio field of user settings after 255 characters #2612
Comments
|
Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label. To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please reach out to us on Discord or follow up on the issue itself. For full info on how to contribute, please check out our contributors guide. |
|
The file to change is app/components/organisms/UserSettingsPage/user-settings-page.tsx Lines 273 to 298 in 3d157ab Here's what needs to be done to fix this {/* Bio section */}
<div className="flex flex-col gap-2">
<label className="flex flex-col w-full text-sm">
Bio
<div className="flex-1 px-2 shadow-input border transition rounded-lg py-1 flex items-center bg-light-slate-4 disabled:cursor-not-allowed focus-within:border-light-orange-9">
<textarea
rows={4}
placeholder="Tell us about yourself."
name="bio"
className="w-full focus:outline-none placeholder:font-normal placeholder-slate-400 bg-inherit"
value={bio}
+ maxLength={255}
onChange={(e) => setBio(e.target.value)}
></textarea>
</div>
</label>
- {bio?.length > 255 ? (
- <p aria-live="assertive" className="text-light-red-10 text-xs">
- Bio too long
- </p>
- ) : (
- <p aria-live="polite" className="text-xs">
- {bio?.length}/255
- </p>
- )}
+ <p aria-live="polite" className="text-xs">
+ {bio?.length}/255
+ </p>
</div> |
nickytonline
added
good first issue
|
.take |
|
.take |
|
Thanks for being interested in this issue. It looks like this ticket is already assigned to a contributor. |
…d after 255 characters (70) Now, it Can't keep typing in the bio field of user settings after 255 characters. Changed the code in user-sttings-page.tsx fix open-sauced#2612
|
.take |
|
is it still open? |
|
@Pagla-Dasu has been working on this and has a PR up for it. Not sure why they weren't assigned. 🤔 |
|
@nickytonline i have raised a pr if possible could u review |
@devharsh2k4, it's already assigned to @Pagla-Dasu and they have a PR up for this. |
We currently display a message saying the bio is too long in the user settings, but we're not leveraging the native maxLength HTML attribute to prevent someone from typing past the limit.
As well, since
maxLengthprevents you from typing or pasting text past 255 characters, thebio too longmessage will actually never appear so it can be removed from the component.This is what happens when
maxLength="255"is set.The text was updated successfully, but these errors were encountered: