Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open-rpc Client.notify does not resolve #309

Open
rowend36 opened this issue May 6, 2022 · 1 comment
Open

open-rpc Client.notify does not resolve #309

rowend36 opened this issue May 6, 2022 · 1 comment

Comments

@rowend36
Copy link

rowend36 commented May 6, 2022

Describe the bug
Websocket.prototype.send does not respect callback argument in some browsers. As a result, open-rpc notify method with Websocket transport never resolves on said browsers.

To Reproduce
Steps to reproduce the behavior:

const client = new Client(new RequestManager(new WebsocketTransport(uri)));

try {
  await client.notify('test')
}finally {
  alert('done')
}

Expected behavior
Expected promise to resolve or reject(and alert 'done')

Smartphone (please complete the following information):

  • OS: Android
  • Browser: Chrome
  • Version 79

Similar
This issue is caused by the same problem.

@frake23
Copy link
Contributor

frake23 commented Oct 9, 2022

Issue is not fixed yet

frake23 added a commit to frake23/client-js that referenced this issue Oct 9, 2022
see th issue for details

fixes issue open-rpc#309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants