Skip to content
This repository has been archived by the owner on Apr 12, 2019. It is now read-only.

Validate Reference #155

Open
mikaelkalt opened this issue Jul 24, 2018 · 4 comments
Open

Validate Reference #155

mikaelkalt opened this issue Jul 24, 2018 · 4 comments

Comments

@mikaelkalt
Copy link
Contributor

mikaelkalt commented Jul 24, 2018

Add Validation for reference / or internal referenz as it is called in the code.

It is mandatory. - I'd recommend to not check the length. @Plattnea suggested a max length of 35 characters which is very PAKT specific.

@mikaelkalt mikaelkalt changed the title Cleanup Reference InternalPersonID etc. Validate Reference Jul 25, 2018
@lennartx
Copy link
Contributor

Such a check should be handled by the adapter itself. #161

@mikaelkalt
Copy link
Contributor Author

Well you're right that the adapter should check the length itself, but I'm not sure if it is mandatory. According to #2 it is not really clear to me.

@lennartx
Copy link
Contributor

I'd suggest #2 has to be changed, and that the Pakt-adapter is responsible for anything that goes beyond the standard node validation. I.e. if the field is indeed mandatory for the Pakt-adapter, it'll have to validate it itself.
Other adapter implementations will have other requirements.

@mikaelkalt
Copy link
Contributor Author

After discussing with @hoehnb this issue will be moved back to the backlog as it would need further discussions. For the moment it is fine if the reference is optional.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants