Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request count / duration metrics for external data providers #3156

Open
mark-adams opened this issue Nov 9, 2023 · 3 comments
Open

Add request count / duration metrics for external data providers #3156

mark-adams opened this issue Nov 9, 2023 · 3 comments

Comments

@mark-adams
Copy link

Describe the solution you'd like
We're currently building an in-house External Data provider. However, there's currently an observability gap where it is difficult to understand the impact that External Data provider latency has on the overall performance of the validation webhook.

To solve this, I'd love to see the addition of the following metrics:

Name: gatekeeper_external_data_provider_request_count
Description: The number of requests made to an external data provider
Tags: external_data_status: [success, system_error], external_data_provider_name: [(provider name attribute)]
Aggregation: Count

Name: gatekeeper_external_data_provider_request_duration_seconds
Description: The external data provider response time in seconds
Tags: external_data_status: [success, system_error], external_data_provider_name: [(provider name attribute)]
Aggregation: Distribution

@mark-adams mark-adams added the enhancement New feature or request label Nov 9, 2023
Copy link

stale bot commented Jan 9, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 9, 2024
@ritazh ritazh removed the stale label Jan 9, 2024
Copy link

stale bot commented Mar 9, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 9, 2024
@maxsmythe maxsmythe removed the stale label Mar 12, 2024
Copy link

stale bot commented May 11, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants