kong_api_authz: Latest Rocks Build #214
Comments
|
Hi @STKarthikAbiram 👋 I don't think we ever published one from this repository. I'm afraid I know almost nothing about Lua or its ecosystem, but if you do and would like to help out, that'd be great :) |
|
Lua is new for me as well. The old repo mentions something about a CI pipeline but the repo is archived: Do we know any contributor from the previous repo? |
|
I'm not sure, but I can ask around. |
|
I learnt that Kong provides this if you're on an enterprise subscription: https://docs.konghq.com/hub/kong-inc/opa/ If you want to use the one provided here, you'll probably have to build it yourself. Or hope that someone with more Lua knowledge than us drops by :) |
|
I would also like an updated rock and was just looking into this today. Steps I think we'll need in order to pull this off:
|
This plugin appears to be entirely different than the source code seen here (as evidenced by different (OPA Input Structure)[https://docs.konghq.com/hub/kong-inc/opa/#opa-input-structure]). Also the Kong plugin is part of their enterprise offering - the plugin featured here is OSS and open to modification. Each seem like a valid use case and I'd vote for maintaining the separate lineage of the plugin featured in this repo. (And publishing updated rocks packages.) |
|
Hi Jesse! Transfering ownership sounds like it might be more work than simply replicating that functionality here, and publish a new project to luarocks, or WDYT? If @wada-ama is around, he might have some thoughts on the matter to share. |
|
Tagging @jeremyjpj0916 - Do you have an opinion on this one or bandwidth to help fix up the luarocks package? |
|
Tried to do something quick and dirty for yah to play with but seems the way it references errors out: Looks like the raw rock was made. I am not familiar with luarocks builds that reference a different source other than its own in the: section.
The guys older rock file looks way smaller at 25kb... maybe I try removing the source ref. https://github.com/luarocks/luarocks/wiki/Rockspec-format#build-rules Makes me think the source ref matters... but the difference in KB sizes makes me think maybe it was a goof to ref that larger repo as part of the source vs his own codebase? |
|
Can try using this, see if it works for your needs: https://luarocks.org/modules/optum-ross/kong-plugin-opa2/0.1.1-2 Dropped the original source ref pointing at the other repo(https://github.com/open-policy-agent/contrib.git), so now it just references the source code of the plugin folder in the rock. |
|
@jeremyjpj0916 Thanks for looking into this. Did we gain much over the status quo by spinning up a new git repo? Isn't that what https://github.com/wada-ama/kong-plugin-opa has in place today? I believe the idea was to get strong linkage between the luarocks package and the authoritative github repo (this one). |
|
The OP wanted a fix that merged the PR into the src of this luarocks package. I think I did that with the version bump the original author had made on the src but didn't ever do a luarocks push. A refactor to embedding this code if the OPA folks want it would be taking my repo, taking the plugin source and embedding it with the rockspec in their repo and becoming maintainers of it in a folder of their repo if they like. The dependency fix should work as is though from what I pushed to luarocks if that referenced repo had the latest kong opa plugin code. The code reads as a independent kong plugin though so honestly embedding it in another mega repo isn't really the kong plugin way. The codebase should have its own maintainable separate repo and ci/cd. Repo here to work with as a ref point: |
|
The contrib repo is largely community maintained, so if it makes sense to move something out of here in favor of a separate repo elsewhere, I have no objections to that. We can still reference it here, on the ecosystem page, the awesome OPA list, and wherever else makes sense. |
|
I just realized the source in that folder in this contrib repo is the same as the plugin source code in the independent repo woth a new PR that was added recently. I would say setting up a separate official kong opa dedicated plugin and readme and ci/cd is def the way to go vs a uber repo. Whether opa wants to maintain it or someone else tries to run with it. Could put it in the Optum OSS space @JesseEstum if opa does not want the burden of maintaining it. |
Good catch! @jeremyjpj0916 you rock :) (lua package manager pun intended).
My vote is for the repo to live in the open-policy-agent org. To denote that it's a contributed plugin, perhaps a name like
Further my vote would be to:
@anderseknert @jeremyjpj0916 @STKarthikAbiram your thoughts? |
|
Thanks for the kind words! I'll go with whatever you decide. Just let me know if/when you need me to do anything. |
|
@JesseEstum I think that makes sense. If part 2 of your further on the luarocks ownership transfer and all that gets to be too delaying I don't think it would be all that bad an idea if there wasn't a new OPA contributor managed luarocks account stood up that could become a fresh updated source of truth for all things around this plugin now. Typically OSS users will find a way to get to the lastest and greatest one way or another. |
|
@JesseEstum I agree with your points.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Team,
The rocks file at https://luarocks.org/modules/wada-ama/kong-plugin-opa is from 3 years ago. Could anyone please let me know where I can get the latest rocks, which would include the fix #146 ?
Thanks!
The text was updated successfully, but these errors were encountered: