Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add icons for hwloc #663

Open
bigon opened this issue Apr 26, 2024 · 1 comment
Open

Please add icons for hwloc #663

bigon opened this issue Apr 26, 2024 · 1 comment

Comments

@bigon
Copy link

bigon commented Apr 26, 2024

Hello,

In #466 an Icon= entry was added in the .desktop file, but no real icon was added.

Could you please add icons for hwlock

XDG specification says:

So, you're an application author, and want to install application icons so that they work in the KDE and Gnome menus. Minimally you should install a 48x48 icon in the hicolor theme. This means installing a PNG file in $prefix/share/icons/hicolor/48x48/apps. Optionally you can install icons in different sizes. For example, installing a svg icon in $prefix/share/icons/hicolor/scalable/apps means most desktops will have one icon that works for all sizes. You might even want to install icons with a look that matches other well known themes so your application will fit in with some specific desktop environment.

I would says that you also should ship 128x128 and 256x256 icons (in addition to 48x48 and .svg/scalable ones) so they looks nice on modern desktop environments too

@bgoglin
Copy link
Contributor

bgoglin commented Apr 26, 2024

Hello. We would if we had a good logo, but we don't. Some proposals exist, including the one in the Android app https://play.google.com/store/apps/details?id=com.hwloc.lstopo&hl=en_US (because it was really required there) but there was no consensus on whether it's a good logo or not. If you want to design one, I'll be happy to include it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants